Bug 458026

Summary: In-Reply-To in notification emails changed format; threading broke
Product: [Community] Bugzilla Reporter: Mark McLoughlin <markmc>
Component: Bugzilla GeneralAssignee: David Lawrence <dkl>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: devel   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1318162 (view as bug list) Environment:
Last Closed: 2008-08-06 16:31:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1318162    
Attachments:
Description Flags
Patch to fix domain name in the in-reply-to mail header (v1) nelhawar: review+

Description Mark McLoughlin 2008-08-06 07:00:25 UTC 
Not worth fixing unless easy to fix, but the email headers used to contain:

  In-Reply-To: <bug-446214-196610.com>

but now contain

  In-Reply-To: <bug-446214-196610.redhat.com/>

so new email threads have been created.

It'd be nice to go back to the old format again
Comment 1 David Lawrence 2008-08-06 15:04:40 UTC 
Verified this is indeed broken. Taking and will fix in the next update.
Comment 2 David Lawrence 2008-08-06 15:38:37 UTC 
Created attachment 313587 [details]
Patch to fix domain name in the in-reply-to mail header (v1)

Patch attached for review to fix the domain name that is in reply to header.
In upstream bugzilla they add the http(s) to the domain name for reasons I am not sure. In 2.18 we had bugzilla.redhat.com as the domain name hard coded into the email template.

The patch hacks the BugMail.pm code to remove the https from the domain name and the trailing slash so it better matches 2.18 behaviour.

Please review

Dave
Comment 3 Noura El hawary 2008-08-06 16:22:52 UTC 
Comment on attachment 313587 [details]
Patch to fix domain name in the in-reply-to mail header (v1)

looks Good Dave, I saw it works fine on bz-web2.

Noura
Comment 4 David Lawrence 2008-08-06 16:31:39 UTC 
Thanks Noura. Checking into CVS and will be in the next update.