Bug 458288
Summary: | Review Request: gitosis - git repository hosting application | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John A. Khvatov <ivaxer> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | a.badger, fedora-package-review, mtasaka, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-27 15:39:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
John A. Khvatov
2008-08-07 14:20:58 UTC
For 0.2-4: ! EVR (epoch-version-release) - Would you tell me whether this tarball is the "pre-release" or "post-release" of the formal 0.2 version? * License - Currently I don't see any evicence that this package is licensed under GPLv2 only. Currently I regard this as licensed under GPL+ (I ignore debian/ directory) * SourceURL - As this uses git repository, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control i.e. write as a comment how you created the tarball * Requires - Please make it sure that all rpms needed for this rpm are correctly listed in Requires. It seems at least "python-nose python-setuptools" is needed for Requires. * README.fedora - Please include this file as SOURCE and not create this file by using cat. Using cat changes the timestamp of this time every time you rebuild this srpm unneededly. * %clean * rm -f README.fedora is not needed. * scriptlets -------------------------------------------------------------- useradd -r -g gitosis -d /var/lib/gitosis -s /bin/sh \ -c "git repository hosting" gitosis -------------------------------------------------------------- - Is the directory %_localstatedir/lib/ unneeded (for %files entry)? This tarball is the "post-release", which I wrote in Release tag as in https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages I have a warnings from rpmlint: $ rpmlint gitosis-0.2-5.20080730git.fc9.noarch.rpm gitosis.noarch: W: non-standard-uid /var/lib/gitosis gitosis gitosis.noarch: W: non-standard-gid /var/lib/gitosis gitosis gitosis.noarch: E: non-standard-dir-perm /var/lib/gitosis 0750 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Why? I create gitosis user and homedir by the package with appropriately permissions (0750). May be switch to fedora-mgmt? Incidentally, a similar package monotone has the same warnings. Fixed: SPEC: http://stingr.net/~ivaxer/gitosis/gitosis.spec SRPM: http://stingr.net/~ivaxer/gitosis/gitosis-0.2-5.20080730git.fc9.src.rpm Sorry for idle. Thanks. Fixed perms /var/lib/gitosis (0755): SPEC: http://stingr.net/~ivaxer/gitosis/gitosis.spec SRPM: http://stingr.net/~ivaxer/gitosis/gitosis-0.2-5.20080730git.fc9.src.rpm Assigning. Okay. * Permission (In reply to comment #2) > I have a warnings from rpmlint: > $ rpmlint gitosis-0.2-5.20080730git.fc9.noarch.rpm > gitosis.noarch: W: non-standard-uid /var/lib/gitosis gitosis > gitosis.noarch: W: non-standard-gid /var/lib/gitosis gitosis > gitosis.noarch: E: non-standard-dir-perm /var/lib/gitosis 0750 > 1 packages and 0 specfiles checked; 1 errors, 2 warnings. > > Why? I create gitosis user and homedir by the package with appropriately > permissions (0750). - If you really want 0750 permission, not 0755, then set explicitly the permission as 0750 (by %attr) and _ignore_ the rpmlint error. * Macros ------------------------------------------------------------ 64 %dir %attr(0755,gitosis,gitosis) /var/lib/gitosis ------------------------------------------------------------ - Please change /var to %{_localstatedir} Please fix or modify these issue when importing this package into Fedora. Other things are okay. ------------------------------------------------------------------------------------ This package (gitosis) is APPROVED by mtasaka ------------------------------------------------------------------------------------ Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". Now I am sponsoring you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Now as koji is up, would you follow "Join" wiki? (CVS request is needed) New Package CVS Request ======================= Package Name: gitosis Short Description: Git repository hosting application Owners: ivaxer Branches: F-9 InitialCC: cvs done. Done. I build gitosis for f9 and submit request for push to updates via bodhi. I inadvertently orphaned package, then revert it (in https://admin.fedoraproject.org/pkgdb/packages/name/gitosis). But status is "Orphaned". What must I do to change it? Thanks. As package db says the owner on devel branch is still you, I don't guess I can change the status. If it doesn't seem you can change the status, add CVS request on this bug to revert the status and set fedora-cvs flag again. Perhaps CVS admins can treat this properly. Package Change Request ====================== Package Name: gitosis I inadvertently orphaned package in devel content. The status remained "orphaned" after reversion. Is it possible to change the status to "Approved"? The specific problem for this package has been fixed but the underlying issue has one remaining problem. * All packages with status Orphaned and an actual owner have been changed to status "Approved" * The backend has been changed to properly set the status to "Approved" when the package is un-orphaned. * The webUI doesn't yet update the status immediatel,y (A page refresh will show the change, though.) Now closing. gitosis-0.2-5.20080730git.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: gitosis New Branches: EL-5 Owners: ivaxer slankes To Mamoru: I can't set fedora-cvs flag to "?" for new branch request. Why? For now I set fedora-cvs flag. cvs done. |