Bug 458396
| Summary: | Review Request: denemo - Graphical music notation program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Roy Rankin <rrankin> |
| Component: | Package Review | Assignee: | Ruben Kerkhof <ruben> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rrankin, ruben |
| Target Milestone: | --- | Flags: | ruben:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-10 12:36:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Roy Rankin
2008-08-07 23:43:41 UTC
Hi Roy,
A few initial comments:
- are the defines on the top of the spec needed? You can just set the Name, Version and Release tags and refer to them in the rest of the spec as %{name}, %{version} and %{release}
- You're using RPM_BUILD_ROOT everywhere, except on line 43, there it's %{buildroot}
- You can use %{_includedir} instead of %{prefix}/include on line 40
- The defattr on line 50 should be %defattr(-,root,root,-)
- Could you pick one of the BuildRoots from https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag?
Ruben, Thanks you the comments. I had already fixed all these issues in the rework I did this morning before I saw your comments. Here is the rework URLs Spec URL: http://download.savannah.gnu.org/releases/denemo/fedora/denemo.spec SRPM URL: http://download.savannah.gnu.org/releases/denemo/fedora/denemo-0.7.9-2.fc9.src.rpm Review for release 2.fc9: * RPM name is OK * Source denemo-0.7.9.tar.gz is the same as upstream * Builds fine in mock rpmlint is not silent: [ruben@slice denemo]$ rpmlint denemo-0.7.9-2.fc10.x86_64.rpm denemo.x86_64: E: explicit-lib-dependency libxml2 denemo.x86_64: W: no-version-in-last-changelog You can probably drop all Requires except bug-buddy because you've listed them in the BuildRequires and rpm will pick them up by itself. Requires simplified pec URL: http://download.savannah.gnu.org/releases/denemo/fedora/denemo.spec SRPM URL: http://download.savannah.gnu.org/releases/denemo/fedora/denemo-0.7.9-3.fc9.src.rpm Thanks Roy, This package is approved. I've just sponsored you in the Fedora Account System. You now can proceed with the rest of the process starting from: https://fedoraproject.org/wiki/PackageMaintainers/Join#Install_the_Client_Tools_.28Koji.29 Please fix the last rpmlint warning before importing your package: denemo.x86_64: W: no-version-in-last-changelog Let me know if you have any questions. New Package CVS Request ======================= Package Name:denemo Short Description:Graphical music notation program Owners:rrankin Branches:F-10 InitialCC: cvs done. Hi Roy, I see you've successfully imported your package. Don't forget to close your review ticket next time, I'll close this one for now. |