Bug 458407

Summary:	Review Request: ibus-anthy - anthy engine for IBus
Product:	[Fedora] Fedora	Reporter:	Peng Huang <phuang>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, tfujiwar
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-13 08:34:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peng Huang 2008-08-08 01:35:17 UTC

Spec URL: http://ibus.googlecode.com/files/ibus-anthy.spec
SRPM URL: http://ibus.googlecode.com/files/ibus-anthy-0.1.0.20080808-1.fc9.src.rpm
Description: It is a Japanese engine for IBus

Comment 1 Parag AN(पराग) 2008-08-08 08:01:11 UTC

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=766012
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d4e97fc37198a3916a9ead39433d411c  ibus-anthy-0.1.0.20080808.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are correct with unnecessary extra dependencies  perl(XML::Parser)
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package ibus-anthy-0.1.0.20080808-1.fc10 =>
  Provides:  _anthy.so
 Requires: /bin/sh libanthy.so.0 libanthydic.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) python(abi) = 2.5 rtld(GNU_HASH)

Suggestions:
  1) Remove extra BR: perl(XML::Parser)
  2) Remove unnecessary line from %files
    %{_datadir}/ibus-anthy/icons/*
    This makes build.log to show 
   warning: File listed twice: /usr/share/ibus-anthy/icons/ibus-anthy.png

APPROVED.

Comment 2 Peng Huang 2008-08-08 08:14:56 UTC

New Package CVS Request
=======================
Package Name: ibus-anthy
Short Description: The Anthy input engine for IBus platform
Owners: phuang
Branches: F-9
InitialCC: phuang
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-08-10 01:29:49 UTC

cvs done.

Comment 4 Peng Huang 2008-08-10 18:14:42 UTC

It has been built in koji.

Comment 5 Peng Huang 2008-08-13 04:53:11 UTC

New Package CVS Request
=======================
Package Name: ibus-anthy
Short Description: The Anthy input engine for IBus platform
Owners: phuang
Branches: EPEL-5
InitialCC: phuang
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-08-13 05:07:37 UTC

cvs done.

Comment 7 fujiwara 2014-10-27 06:19:47 UTC

Package Change Request
======================
Package Name: ibus-anthy
New Branches: epel7
Owners: fujiwara
InitialCC: i18n-team

Comment 8 Gwyn Ciesla 2014-10-27 11:57:56 UTC

Git done (by process-git-requests).