Bug 458408
| Summary: | Review Request: vttest - Test the compatibility of so-called "VT100-compatible" terminals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sindre Pedersen Bjørdal <sindrepb> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i, mlichvar, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-01 18:20:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sindre Pedersen Bjørdal
2008-08-08 01:39:16 UTC
License seems to be MIT, not BSD. It's just the " Old Style with legal disclaimer" from http://fedoraproject.org/wiki/Licensing/MIT with the MIT references removed or replaced. You probably don't want to use %{__mv} and %{__rm} in %prep but instead want the non-macro versions to match the rest of your spec. * source files match upstream: 6c754405c1b9af2a28ba0975058ef8a38da230bc8c8e0874aebcbe2ff24dee7d vttest.tar.gz * package meets naming and versioning guidelines. * specfile is properly named and is cleanly written X macros not used consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field should read "MIT". * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none) * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: vttest = 20071216-1.fc10 vttest(x86-64) = 20071216-1.fc10 = vttest-debuginfo-20071216-1.fc10.x86_64.rpm vttest-debuginfo = 20071216-1.fc10 vttest-debuginfo(x86-64) = 20071216-1.fc10 = * %check is not present; no test suite upstream. I ran this manually in the mock chroot and it seems to work fine. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. Updated: - License change to MIT - Changed macro usage in %prep Spec URL: http://sindrepb.fedorapeople.org/packages/vttest.spec SRPM URL: http://sindrepb.fedorapeople.org/packages/vttest-20071216-2.fc9.src.rpm One detail, better source URL to use is ftp://invisible-island.net/vttest/vttest-%{version}.tgz so we won't have different versions saved in file with the same name. Updated: - Update source url Spec URL: http://sindrepb.fedorapeople.org/packages/vttest.spec SRPM URL: http://sindrepb.fedorapeople.org/packages/vttest-20071216-3.fc9.src.rpm Looks good to me now. APPROVED New Package CVS Request ======================= Package Name: vttest Short Description: Test the compatibility of so-called "VT100-compatible" terminals Owners: sindrepb Branches: F-8 F-9 EL-4 EL-5 InitialCC: cvs done. Package Change Request ====================== Package Name: vttest New Branches: epel7 Owners: cicku maxamillion Git done (by process-git-requests). |