Bug 458409
| Summary: | Review Request: ibus-pinyin - PinYin engine for IBus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Huang <phuang> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-13 08:34:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peng Huang
2008-08-08 01:49:50 UTC
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=766028 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 21ddfc9307ac154f0360a36f64dd97f2 ibus-pinyin-0.1.0.20080808.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct with unnecessary extra dependencies perl(XML::Parser) gtk2-devel qt-devel + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions: 1) Remove extra BR: perl(XML::Parser) pygtk2 gtk2-devel qt-devel 2) Remove unneeded lines from SPEC %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} APPROVED. New Package CVS Request ======================= Package Name: ibus-pinyin Short Description: The Chinese PinYin input engine for IBus platform Owners: phuang Branches: F-9 InitialCC: phuang Cvsextras Commits: yes cvs done. It has been built in koji. New Package CVS Request ======================= Package Name: ibus-pinyin Short Description: The Chinese PinYin input engine for IBus platform Owners: phuang Branches: EPEL-5 InitialCC: phuang Cvsextras Commits: yes cvs done. |