Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 458507

Summary: Memory leak setting new password storage scheme
Product: [Retired] 389 Reporter: Rich Megginson <rmeggins>
Component: Security - Password PolicyAssignee: Rich Megginson <rmeggins>
Status: CLOSED ERRATA QA Contact: Chandrasekar Kannan <ckannan>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.1.1CC: benl, jgalipea, jlieskov, nhosoi, nkinder, security-response-team
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: comment#1.review+nhosoi
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-27 20:39:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 249650, 452721, 453229    
Attachments:
Description Flags
diffs
none
cvs commit log - DS8.0
none
cvs commit log - HEAD none

Description Rich Megginson 2008-08-08 23:52:15 UTC
In config_set_pw_storagescheme, new_schema is allocated in both the non apply and the apply case, but it is only freed in the apply case.

Comment 1 Rich Megginson 2008-08-08 23:53:27 UTC
Created attachment 313858 [details]
diffs

Comment 2 Noriko Hosoi 2008-08-09 14:39:15 UTC
> but it is only freed in the apply case.

Rather, consumed, isn't it? ;)
slapdFrontendConfig->pw_storagescheme = new_scheme;

Comment 5 Rich Megginson 2008-08-11 16:36:57 UTC
This bug can only be reproduced by an admin user changing the password storage scheme, not an anonymous user.  You have to authenticate then have special privileges.

Comment 6 Rich Megginson 2008-08-12 22:27:03 UTC
Created attachment 314145 [details]
cvs commit log - DS8.0

Reviewed by: nkinder (Thanks!)
Fix Description: In config_set_pw_storagescheme, new_schema is allocated in both the non apply
and the apply case, but it is only freed in the apply case.  The solution is to free it in the non apply case.
Platforms tested: RHEL5, Fedora 8
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none

Comment 8 Jenny Severance 2008-08-19 20:25:22 UTC
How can QE verify this?  What to look for in the valgrind output?

Comment 9 Rich Megginson 2008-08-19 20:28:45 UTC
(In reply to comment #8)
> How can QE verify this?  What to look for in the valgrind output?

Look for a memory leak in config_set_pw_storagescheme in the valgrind output.

Comment 10 Jenny Severance 2008-08-21 17:46:20 UTC
verified 8.0 RHEL4-32, RHEL4-64, RHEL5-32, RHEL5-64

Comment 13 errata-xmlrpc 2008-08-27 20:39:08 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2008-0602.html

Comment 14 Rich Megginson 2008-08-27 21:07:52 UTC
Created attachment 315145 [details]
cvs commit log - HEAD