Bug 458538

Summary: bug in patch 12: eclipse-launcher-set-install-dir-and-shared-config.patch
Product: [Fedora] Fedora Reporter: Igor Vlasenko <viy>
Component: eclipseAssignee: Andrew Overholt <overholt>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: oliver, overholt
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-11 21:56:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
redesigned and cleaned up patch (w/o -g part)
none
redesigned and cleaned up patch (-g part) none

Description Igor Vlasenko 2008-08-09 14:18:12 UTC 
Created attachment 313878 [details]
redesigned and cleaned up patch (w/o -g part)

Description of problem:
patch contains a line which cause string overflow
the problematic place is here:
< +     programDir = malloc( (_tcslen( temp + 1 )) * sizeof(_TCHAR) );
---
> +     programDir = malloc( (_tcslen( temp ) + 1) * sizeof(_TCHAR) );

Version-Release number of selected component (if applicable):
eclipse-3.3.2-12
Comment 1 Igor Vlasenko 2008-08-09 14:19:32 UTC 
Created attachment 313879 [details]
redesigned and cleaned up patch (-g part)
Comment 2 Andrew Overholt 2008-08-11 15:25:21 UTC 
Hi Igor,

Thanks for updating the patch.  Unfortunately, it's no longer needed.  I'm sorry if this wasted your time at all :(

Andrew
Comment 3 Igor Vlasenko 2008-08-11 21:56:15 UTC 
fine