Bug 458543

Summary: Review Request: eg - a wrapper for Git
Product: [Fedora] Fedora Reporter: Adam Huffman <bloch>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dan, fedora-package-review, notting, opensource
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-10 18:13:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adam Huffman 2008-08-09 15:47:28 UTC 
Spec URL: http://verdurin.fedorapeople.org/review/eg/eg.spec

SRPM URL: http://verdurin.fedorapeople.org/review/eg/eg-0.85-1.fc10.src.rpm

Description: Easy Git (eg) is a wrapper for git, designed to make Git easy to learn and use.

rpmlint on the .spec file:

eg.spec:61: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

0 packages and 1 specfiles checked; 1 errors, 0 warnings.

I would welcome advice on how to get around this error - there is only a single source file (not an archive), which constitutes the entire package.

eg.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

As mentioned above, there are no other files in the source.  Is it normal to create something like 'README.Fedora' in this case?
Comment 1 Jason Tibbitts 2008-08-09 16:47:46 UTC 
> eg.spec:61: E: use-of-RPM_SOURCE_DIR
> You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
> a directory for building, use $RPM_BUILD_ROOT instead.

It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be easier to install %{SOURCE0} directly?

> As mentioned above, there are no other files in the source.  Is it normal to
> create something like 'README.Fedora' in this case?

You don't need to invent documentation where none exists.  You could, however, consider writing a manpage and sending it upstream.
Comment 2 Till Maas 2008-08-10 14:24:34 UTC 
(In reply to comment #1)
> > eg.spec:61: E: use-of-RPM_SOURCE_DIR
> > You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
> > a directory for building, use $RPM_BUILD_ROOT instead.
> 
> It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be
> easier to install %{SOURCE0} directly?

Imho it the source should be copied to the build-dir in %setup, therefore instead of
cp $RPM_SOURCE_DIR/%{name} $RPM_BUILD_DIR/%{name}-%{version}
this would be better in %prep:

cp -p %SOURCE0 .

I did not test it, but imho it should work. Also note the "-p" to preserve the timestamp.

When %SOURCE0 would be directly installed in %install, then it make much more work to create a patch, e.g. I normally run make prep, create the patch and use "make patch SUFFIX=foo" in Fedora CVS.
Comment 3 Dan Horák 2008-08-10 18:13:35 UTC 

*** This bug has been marked as a duplicate of bug 442914 ***