Bug 458588

I'm not quite sure why you have the alphatag and such in the version.  It looks to me as if this is a post-release update, not a prerelease paackage.  If so, why not  just use an NVR like qsstv-5.23c-1%{?dist} ?

(In reply to comment #1)
> It looks
> to me as if this is a post-release update, not a prerelease paackage.  If so,
> why not  just use an NVR like qsstv-5.23c-1%{?dist} ?

Yes this is a post-release, I've corrected the files:

http://lucilanga.fedorapeople.org/qsstv.spec
http://lucilanga.fedorapeople.org/qsstv-5.3c-1.fc9.src.rpm

I find that I can't fetch the upstream source from the Source0 URL in the spec; 
http://users.telenet.be/on4qz/qsstv/download/qsstv-5.3c.tar.gz seems to be the proper location.  The "snapshots" directory holds version 6.0a.

That, of course, begs the question of whether you would prefer to package 6.0a instead.  I can go ahead and review this version, however.

The only other issue I see is that there is no desktop file.  As this is a GUI application, Fedora requires that a desktop file be provided by the package.

* source files match upstream (using corrected URL):
   26094e95eb7e2a6728b8d3bde7aee91cb1ce2f6167dd58a8e47c778f405099ad  
   qsstv-5.3c.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   qsstv = 5.3c-1.fc10
   qsstv(x86-64) = 5.3c-1.fc10
  =
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libgcc_s.so.1()(64bit)
   libpng12.so.0()(64bit)
   libqt-mt.so.3()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libz.so.1()(64bit)

* %check is not present; no test suite upstream.  I honestly haven't a clue as 
   to how I could test this, but I ran the program and it opened windows and 
   suck without crashing.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X A GUI application with no desktop file

(In reply to comment #3)

> I find that I can't fetch the upstream source from the Source0 URL in the spec; 
> http://users.telenet.be/on4qz/qsstv/download/qsstv-5.3c.tar.gz seems to be the
> proper location.
Corrected Source0

> The "snapshots" directory holds version 6.0a.
> That, of course, begs the question of whether you would prefer to package 6.0a
> instead.  I can go ahead and review this version, however.
I would prefer 5.3c.


> The only other issue I see is that there is no desktop file.  As this is a GUI
> application, Fedora requires that a desktop file be provided by the package.
Added png and desktop file

and bounced version:
http://gnome.eu.org/qsstv.spec
http://gnome.eu.org/qsstv-5.3c-2.fc9.src.rpm

This now fails to build because of a missing dependency on desktop-file-utils.  I added it and the package builds OK.  The desktop file installs fine.

Since you can't build anyway without that missing dependency, I'll just approve this and you can fix it when you check in.

APPROVED

New Package CVS Request
=======================
Package Name: qsstv
Short Description: Qt-based slow-scan TV and fax
Owners: lucilanga
Branches: F-8 F-9 EL-5
InitialCC: 
Cvsextras Commits: yes

cvs done.

qsstv-5.3c-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/qsstv-5.3c-3.fc9

qsstv-5.3c-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/qsstv-5.3c-3.fc8

qsstv-5.3c-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

qsstv-5.3c-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: qsstv
New Branches: epel7
Owners: hobbes1069
InitialCC: lucilanga

Git done (by process-git-requests).