Bug 458593

Summary: noisy squid initscript
Product: [Fedora] Fedora Reporter: Curtis Doty <curtis>
Component: squidAssignee: Jiri Skala <jskala>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: medium    
Version: 9CC: aglotov, henrik, hno, jonathansteffan, jskala, mnagy
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-07 10:01:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Curtis Doty 2008-08-10 16:55:32 UTC 
+++ This bug was initially created as a clone of Bug #428998 +++

The patch now outputs superfluous crud during startup, even when no errors exist.

Instead, maybe it should save the stderr for selective output...something like this:

--- squid.orig  2008-07-02 02:32:13.000000000 -0700
+++ squid       2008-08-10 09:47:37.000000000 -0700
@@ -62,12 +62,13 @@
 start() {
        probe
 
-       $SQUID -k parse
+       parse=`$SQUID -k parse 2>&1`
        RETVAL=$?
        if [ $RETVAL -ne 0 ]; then
                echo -n $"Starting $prog: "
                echo_failure
                echo
+               echo "$parse"
                return 1
        fi
        for adir in $CACHE_SWAP; do
Comment 1 Henrik Nordstrom 2008-08-10 18:42:35 UTC 
This is partially an upstream bug. "squid -k parse" is supposed to be silent if there is no warnings, but it currently is not..

The proposed initscript change looks fine to me.