Bug 458746
| Summary: | Review Request: python-netaddr - Network address manipulation, done Pythonically | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John Eckersberg <jeckersb> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, ruben |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-13 20:20:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
John Eckersberg
2008-08-12 02:45:02 UTC
I see duplication of document files installed. Remove docs/api/* from %docs update SRPM and SPEC. Also, You should add tests to %doc but this will make rpmlint to complain spurious-executable-perm warning. For that you should add following line to %prep chmod 644 tests/* (In reply to comment #1) > I see duplication of document files installed. Remove docs/api/* from %docs > update SRPM and SPEC. > > Also, You should add tests to %doc but this will make rpmlint to complain > spurious-executable-perm warning. For that you should add following line to > %prep > chmod 644 tests/* I have removed the duplicate docs, added the tests and fixed the permissions so rpmlint is clean. Re-uploaded the spec and srpm to the original URLs above. Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=774764 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 9f6450c2b868964afea248fa2a2af0f4 netaddr-0.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions:- Kindly make habit of always updating release in SPEC and adding changelog of what changed from last SRPM upload. This will avoid any confusion for reviewer also. you should now add changelog before importing this package to CVS. APPROVED. New Package CVS Request ======================= Package Name: python-netaddr Short Description: Network address manipulation, done Pythonically Owners: jeckersb Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Built in Koji for F-8,9,10. *** Bug 460386 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: python-netaddr New Branches: EL-4 EL-5 Owners: jeckersb CVS Done |