Bug 458994

I'll do this one.

MUST:
Y: rpmlint on each package
Y: Meeting Package Naming Guidelines
Y: Spec file name matches base package name
Y: License field is valid                  
Y: Meets Packaging Guidelines              
 Y: License included in package (if included in source)
 Y: Spec file written in en_US                         
 Y: Spec file is legible                               
 Y: Sources match upstream source                      
 Y: Source URL 'sane'                                  
 Y: Compiles successfully - [noarch]                   
 -: ExcludeArch required?                              
 Y: All Build Dependencies Listed                      
 -: Handles locales sanely                             
 -: Library packages run ldconfig                      
 Y: Package is not relocatable                         
 Y: Package owns all directories created               
 Y: No duplicate file listings                         
 Y: defattr set correctly
 Y: %clean is used
 Y: Macro use conisistant
 Y: ONLY Contains Code/Content that is allowed
 -: Large Documentation in -doc subpackage
 Y: %doc must not affect package runtime
 -: Header files in -devel
 -: Static libraries in -static
 -: pkgconfig files require pkgconfig
 -: Library files are located in correct package
 -: -devel requires base package w/ fully versioned dependency
 -: Packages do not contact .la (libtool) archives
 Y: GUI Apps have .desktop files
 Y: No duplicate directory ownerships
 Y: %install cleans buildroot
 Y: Filenames are valid UTF-8

SHOULD:
-: Description/Summary sections contain translations
Y: Builds in mock/koji
Y: Builds on all architectures
Y: Program works upon testing
Y: Scriptlets are sane
-: Subpackages require base package
-: pkgconfig.pc files in -devel
-: File dependencies should only be in /etc /bin /sbin /usr/bin /usr/sbin


APPROVED

New Package CVS Request
=======================
Package Name: liveusb-creator
Short Description: A liveusb creator
Owners: kushal, lmacken
Branches: F-9 EL-5
InitialCC: kushal
Packager Commits: yes

cvs done.

The %files section of this package is broken:

  %{_datadir}/*

does not work, because now liveusb-creator also owns

  %{_datadir}/applications and
  %{_datadir}/pixmaps

Kushal, please use something like

  %{_bindir}/*
  %{_sbindir}/*
  %{_datadir}/pixmaps/*.png
  %{_datadir}/applications/*.desktop

or even better: 

  %{_bindir}/%{name}
  %{_sbindir}/%{name}
  %{_datadir}/pixmaps/fedorausb.png
  %{_datadir}/applications/fedora-%{name}.desktop

This way you make sure you don't accidentally package unwanted files.

Nigel, please review more carefully next time, "No duplicate directory ownerships" should really mean "No duplicate directory ownerships". ;)