Bug 459148

Summary: Review Request: txt2rss - Convert from txt to rss
Product: [Fedora] Fedora Reporter: Rakesh Pandit <rpandit>
Component: Package ReviewAssignee: Rahul Sundaram <sundaram>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, smohan, sundaram
Target Milestone: ---Flags: sundaram: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-06 07:56:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Rakesh Pandit 2008-08-14 18:19:43 UTC
Description:
txt2rss is a shell script that parses a simple txt file (in a simple
format) and convert it to RSS feed file. Simple to use and intuitive,
you need to set up a config file with parameter like webmaster's name,
link of the site and others, after you just call the script with
options like <input file> and a <output file>.

SPEC: http://rakesh.fedorapeople.org/spec/txt2rss.spec
SRPM: http://rakesh.fedorapeople.org/srpm/txt2rss-0.1-1.fc9.src.rpm

Comment 1 Jason Tibbitts 2008-08-15 22:40:09 UTC
There is absolutely no mention of anything license-related in the source code.  All we have is the upstream web site, but it's been long enough since this has come up that I don't recall if that's sufficient.

While I ask the right people, could you ask upstream to at least mention "GPLv3" somewhere in their code, and if possible to actually follow the suggestions in the GPL and put a copy of it in the tarball/zip and the proper license block in the code?

Comment 2 Rakesh Pandit 2008-08-16 04:57:41 UTC
http://code.google.com/p/txt2rss/issues/detail?id=2
Informed upstream. Waiting for response.


http://code.google.com/p/txt2rss/issues/detail?id=1
I have confirmed about version here.

Comment 3 Rakesh Pandit 2008-08-27 01:51:14 UTC
Confirmed upstream, that it is GPLv3. A license block will shortly be on scripts.

Comment 5 Rahul Sundaram 2008-09-02 13:31:33 UTC
I haven't done a scratch build but otherwise looks sane. The only problem I see is the lack of the license text within the package. You MUST include a copy of the license. This is recommended by the guidelines and mandated by the GPL license

Also as a recommendation, we need a man page.

Comment 6 Rakesh Pandit 2008-09-02 15:54:16 UTC
Thanks,
I have reported upstream that they should include license file in there source.
http://code.google.com/p/txt2rss/issues/detail?id=4 Upstream has confirmed that it will be included ASAP.

I do not consider these issues as blockers but rather in a SHOULD list.

between I have added a man page and submitted it upstream as well.
SPEC: http://rakesh.fedorapeople.org/spec/txt2rss.spec
SRPM: http://rakesh.fedorapeople.org/srpm/txt2rss-0.1-3.fc9.src.rpm

Comment 7 Rahul Sundaram 2008-09-05 14:44:37 UTC
APPROVED

Comment 8 Rakesh Pandit 2008-09-05 14:48:57 UTC
New Package CVS Request
=======================
Package Name: txt2rss
Short Description: Convert from txt to rss
Owners: rakesh
Branches: F-8 F-9
InitialCC: rakesh
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2008-09-05 16:38:56 UTC
cvs done.

Comment 10 Fedora Update System 2008-09-06 07:43:38 UTC
txt2rss-0.1-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/txt2rss-0.1-3.fc9

Comment 11 Fedora Update System 2008-09-06 07:45:07 UTC
txt2rss-0.1-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/txt2rss-0.1-3.fc8

Comment 12 Fedora Update System 2008-10-01 06:33:29 UTC
txt2rss-0.1-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2008-10-01 06:39:28 UTC
txt2rss-0.1-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.