Bug 459198
Summary: | Review Request: prelude-notify - Prelude Notification Applet | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve Grubb <sgrubb> |
Component: | Package Review | Assignee: | Peter Vrabec <pvrabec> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, pvrabec |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | pvrabec:
fedora-review+
kevin: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-25 22:21:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Steve Grubb
2008-08-14 21:44:44 UTC
OK: rpmlint prelude-notify-0.9-0.1.svn10860.fc9.src.rpm NOT OK: rpmlint /home/pvrabec/RPM/RPMS/i386/prelude-notify- 0.9-0.1.svn10860.fc9.i386.rpm prelude-notify.i386: W: incoherent-version-in-changelog 0.1.svn10860 0.9-0.1.svn10860.fc9 prelude-notify.i386: E: no-binary - shouldn't it be marked as noarch? NOT OK: Package Naming Guidelines - add COPYING and AUTHORS file - install desktop file by desktop-file-install OK: Licensing Guidelines OK: License field in the package spec file OK: American English OK: spec file for the package MUST be legible OK: The sources match the upstream source OK: successfully compile OK: ExcludeArch OK: BuildRequires OK: locales OK: shared library files OK: Prefix: /usr OK: own all directories OK: duplicate files in the %files OK: Permissions on files OK: clean section OK: macros OK: documentation files OK: %doc, it must not affect the runtime of the application OK: Header files must be in a -devel package OK: Static libraries must be in a -static package OK: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK: library files with a suffix OK: fully versioned dependency OK: Packages must NOT contain any .la libtool archives OK: GUI applications must include a %{name}.desktop OK: not own files or directories already owned by other packages OK: package MUST run rm -rf %{buildroot} OK: valid UTF-8 Ok, new packages uploaded. The srpm changed names. You can find it here: http://people.redhat.com/sgrubb/files/prelude-notify-0.9-0.1.20080814svn10860.fc9.src.rpm I think this addresses everything above. Note that the svn stuff is only until there is a release which is due today or next week. After that I won't be taking svn snaps. :) Thanks. package approved New Package CVS Request ======================= Package Name: prelude-notify Short Description: Prelude Notification Applet Owners: sgrubb Branches: F-9 InitialCC: Cvsextras Commits: no I suppose uberpackagers would be OK for cvsextras commits. This is a security package. TIA. Erm, sorry, I must have errantly clicked something. cvs done. Package was imported and built. Closing. Thanks everyone. |