Bug 459271
| Summary: | Review Request: ktune - Server performance tuning | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Thomas Woerner <twoerner> |
| Component: | Package Review | Assignee: | Phil Knirsch <pknirsch> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.3 | CC: | dmach, notting, pknirsch, pm-rhel, rvokal, twoerner |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-18 16:51:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188273, 455399, 459272 | ||
|
Description
Thomas Woerner
2008-08-15 15:03:41 UTC
Here are new packages with some changes: Spec URL: http://people.redhat.com/twoerner/BZ/455399/ktune.spec SRPM URL: http://people.redhat.com/twoerner/BZ/455399/ktune-0.2-1.src.rpm Description: ktune provides settings for server performance tuning. Please have a look at /etc/sysconfig/ktune and /etc/sysctl.ktune for tuning parameters. Changes: - new variable ELEVATOR_TUNE_DEVS in /etc/sysconfig/ktune to define the tunable devices, also tune cciss devices - be more verbose for elevator settings - added post and preun scripts The initial version can be found in http://people.redhat.com/twoerner/BZ/455399/0.1-1/ rpmlint ktune-0.2-1.src.rpm: > ktune.src: W: no-%prep-section Just add an empty %prep section > ktune.src: W: no-%build-section Just add an empty %build section > ktune.src: W: summary-not-capitalized ktune - Server performance tuning How about: "Server performance tuning service"? > ktune.src: W: invalid-license GPL Should probably be GPLv2 > ktune.src: W: no-url-tag Thats fine, no upstream repo for that yet. Depending on how this evolves might want to make a fedorahosted project out of it at some point. > ktune.src: W: strange-permission ktune.init 0755 Does it have to be executable in the source file? Using install -m 755 should take care of that during installation, no? rpmlint /home/devel/pknirsch/rpm/rpms/noarch/ktune-0.2-1.noarch.rpm: > ktune.noarch: W: no-documentation Thats fine, documentation needs to be added sometime in the future though (manpage, /usr/share/doc README etc) > ktune.noarch: E: executable-marked-as-config-file /etc/sysconfig/ktune Looks wrong. > ktune.noarch: E: script-without-shebang /etc/sysconfig/ktune See above. > ktune.noarch: E: executable-marked-as-config-file /etc/sysctl.ktune Looks wrong. > ktune.noarch: E: script-without-shebang /etc/sysctl.ktune See above. > ktune.noarch: W: summary-not-capitalized ktune - Server performance tuning See summary for srpm > ktune.noarch: W: invalid-license GPL See license suggestion for srpm > ktune.noarch: W: no-url-tag Fine, see srpm > ktune.noarch: W: service-default-enabled /etc/rc.d/init.d/ktune Is that correct and wanted? I suppose so, as the package won't be installed by default and when manually installed should probably execute the script during startup automatically. Read ya, Phil Ok, here are new packages with some changes: Spec URL: http://people.redhat.com/twoerner/BZ/455399/ktune.spec SRPM URL: http://people.redhat.com/twoerner/BZ/455399/ktune-0.2-2.src.rpm Description: ktune provides settings for server performance tuning. Please have a look at /etc/sysconfig/ktune and /etc/sysctl.ktune for tuning parameters. [pknirsch@hamburg rpm]$ rpmlint ktune-0.2-2.src.rpm ktune.src: W: no-url-tag [pknirsch@hamburg rpm]$ rpmlint ktune-0.2-2.noarch.rpm ktune.noarch: W: no-documentation ktune.noarch: W: no-url-tag ktune.noarch: W: service-default-enabled /etc/rc.d/init.d/ktune Alright, looks good now. Also, assigned the bug to me and removed it from RHEL-NEW tracker bug and moved it to RHEL-ACCEPTED. Thanks, Read ya, Phil Can you please add a %{?dist} to the release?
Package name should be something like: ktune-0.2-2.el5.src.rpm.
Fixed in ktune-0.2-3.el5 which is included in the RHEL-5.3 errata. See: http://errata.devel.redhat.com/errata/show/7807 Closing this bug as per http://intranet.corp.redhat.com/ic/intranet/PackageListProcess Thanks & regards, Phil |