Bug 459305
| Summary: | %lang tagging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | ||||
| Component: | libgweather | Assignee: | Dan Winship <danw> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ville.skytta | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-10-14 18:02:44 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Matthias Clasen
2008-08-15 21:43:49 UTC
Created attachment 314827 [details]
%lang'ify Locations.*.xml
Incidentally, I did this about a week ago, see attached patch.
It also contains an unrelated hunk which moves xsltproc from %install to %build where it is IMO better placed, as well as uses xmllint --noblanks to do the whitespace reduction which also feels better than editing XML with sed (although it's pretty trivial in this case).
Ah, cool. I tried to do this earlier in the week, but no cvs...
I don't really know rpmspec-ese, so I can't say if this is right, although just looking at the diff, I think this part:
+xsltproc %{SOURCE1} data/Locations.xml > data/loc.xml
+xmllint --noblanks data/loc.xml > data/Locations.xml
(which you moved from install-time to make-time) is irrelevant now, because libgweather does --noblanks itself in 2.24.
Seems so indeed, already in 2.23.6. Matthias committed this a while ago |