Bug 459499

Summary: proc_loginuid_write() uses simple_strtoul() on non-terminated array
Product: Red Hat Enterprise Linux 4 Reporter: R. Keyes <rkeyes.bugs>
Component: kernelAssignee: Cong Wang <amwang>
Status: CLOSED ERRATA QA Contact: Evan McNabb <emcnabb>
Severity: low Docs Contact:
Priority: medium    
Version: 4.4CC: onestero, rkhan, vgoyal
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-16 15:56:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Source code to demonstrate the issue none

Description R. Keyes 2008-08-19 14:23:14 UTC 
Created attachment 314547 [details]
Source code to demonstrate the issue

Description of problem:
Current RHEL kernel sources (2.6.9-78.0.1 at the time of this writing) have the earlier backported patch from 2.6.10 which allows the loginuid to be handled in proc. However, they do not have the patch from 2.6.17-rc5 that fixes the use of a non-terminated array in the proc_loginuid_write function. As such, multiple repeated calls to proc_loginuid_write code can result in invalid auid being assigned to the user.

Version-Release number of selected component (if applicable):


How reproducible:
Can take some time but repeatedly calling the affected code will eventually cause it (few minutes to an hour on my tested machines).

Steps to Reproduce:
1. Compile attached c program with "-laudit" options
2. Run compiled program as root and wait
3.
  
Actual results:
Depends on what is in the kernel buffer.

Expected results:
Should always set it to what we called it with.

Additional info:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm1/broken-out/git-audit-master.patch
Comment 1 Oleg Nesterov 2009-07-01 06:31:17 UTC 
I think you are right, we need the unchanged upstream
e0182909297da8d38a5d473ae7bee3d0324632a1 commit.
Comment 2 RHEL Program Management 2009-07-13 13:23:47 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 3 Vivek Goyal 2009-07-14 18:51:15 UTC 
Committed in 89.6.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Comment 10 errata-xmlrpc 2011-02-16 15:56:26 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0263.html