Bug 459858
| Summary: | Review Request: ibus-table - The general table engine for IBus platform | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Huang <phuang> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-24 22:53:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peng Huang
2008-08-23 03:21:28 UTC
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=781102 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1cfc4d7492b276aae3c5bb685182af75 ibus-table-0.1.1.20080823.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions:- you should correct license file COPYING to GPLv2 text. Use make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install to preserve timestamps. APPROVED. are you going to submit ibus-table-zhengma, ibus-table-wubi these packages also or will be adding in future releases? New Package CVS Request ======================= Package Name: ibus-table Short Description: The general table engine for IBus platform Owners: phuang Branches: F-9 EL-5 InitialCC: phuang Cvsextras Commits: yes cvs done. built it. Thanks for Kevin & Parag. |