Bug 459892
Summary: | Review Request: rubygem-mocha - Mocking and stubbing library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, kevin, matt, mfojtik, mtasaka, notting, s.a.hartsuiker |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | kevin:
fedora-review+
j: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rubygem-mocha-0.9.8-1.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-27 21:32:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 593274 |
Description
Jeroen van Meeuwen
2008-08-23 20:42:17 UTC
Added ruby(abi) = 1.8 Requires; New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/rubygem-mocha-0.9.0-2.fc10.src.rpm RPM Lint: quiet Package name: ok Spec file: ok License: wrong Actual License: Dual license Ruby and MIT %doc License: n/a Spec file language: ok Spec file readable: ok Upstream source vs. used tarball: ok (md5: 214b9e794a3d0b71d63f0d26a500e00e) Compile and Build: - F-8: ok - F-9: ok - F-10: ok - rawhide: ok - EL-5: n/a Applicable Package Guidelines: ok Locales: n/a Shared libs: n/a Relocatable: no Directory and file ownership: ok No duplicate files in %files: ok File Permissions: ok Macro usage: ok Code vs. Content: ok (Large) Documentation: n/a %doc affecting runtime: ok Header files in -devel package: n/a Static Libraries in -static package: n/a pkgconfig Requires: n/a Library files: n/a Devel requires base package: n/a .la libtool archives: n/a Duplicate ownership of files/directories: ok Remove BuildRoot: ok UTF-8 filenames: ok the MIT-LICENSE file is not marked as %doc The spec file in the above post from Jeroen is not the same as the spec used in building the srpm... Oh, you're right.. the spec file should have been 0.9.0-2... New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-mocha-0.9.1-1.fc9.src.rpm License tag is wrong. I should be Dual license Ruby/MIT %doc tag is fixed New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-mocha-0.9.1-2.fc9.src.rpm ok, license also fixed. Package APPROVED. New Package CVS Request ======================= Package Name: rubygem-mocha Short Description: Mocking and stubbing library Owners: kanarip Branches: EL-4 EL-5 F-8 F-9 devel InitialCC: Why do you create gem by "rake package" instead of using gem file provided by upstream? I prefer using tarballs because they make the %doc available directly as %doc README etcetera which are then being put in /usr/share/doc/%{name}-%{version}/, rather then putting the docs in some obscure %{geminstdir} (which should hold the program, not the docs) or %{gemdir}/doc/ (which should have RDoc documentation, not READMEs) This seems to fail at least: "The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version " Can you please re-check against: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gems Revised packaging strategy as far as that is concerned: New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-mocha-0.9.1-3.fc9.src.rpm Well, would you check if all files under %geminstdir are really needed at any time for this package? IMO the files under %geminstdir/examples, %geminstdir/tests/ (and also these directories themselves) can be marked as %doc. Also %geminstdir/[A-Z]* should be marked as %doc. Marked these files as %doc New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/rubygem-mocha-0.9.1-4.fc10.src.rpm Oh shoot. I probibly dropped the ball here. Thanks for updating the bug Mamoru. S.A: Would you like to re-review the package from comment #13? I think my concerns are fixed... if you prefer, I could give it a full review as well. Kevin, I'd appreciate if you take over the review; Stefan isn't going to any time soon I suspect Sorry for the long delay here. - 0.9.5 is current now. :) - There are a bunch of 'warning: File listed twice...' messages, due to listing some files twice in the %files section, can you fix that up? (In reply to comment #16) > Sorry for the long delay here. > > - 0.9.5 is current now. :) > "Fixed" ;-) > - There are a bunch of 'warning: File listed twice...' messages, due to listing > some files twice in the %files section, can you fix that up? Fixed too. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec New SRPM: http://www.kanarip.com/custom/f11/SRPMS/rubygem-mocha-0.9.5-1.fc11.src.rpm I see no further blockers here, this package is APPROVED. Care to request cvs here? Jeroen, ping? Well, I will once want to close this review request and I want to take over this package. Jeroen, if you want to co-maintain this package, please visit the new review request I will submit. *** This bug has been marked as a duplicate of bug 507649 *** New Package CVS Request ======================= Package Name: rubygem-mocha Short Description: Mocking and stubbing library Owners: kanarip Branches: EL-4 EL-5 F-10 F-11 devel InitialCC: *** Bug 507649 has been marked as a duplicate of this bug. *** Can you guys work out which of these are going to be used and who is going to maintain? So, Jeroen, if you want to be the maintainer of this package, I will be happy with it. Please set cvs flag again. (In reply to comment #26) > So, Jeroen, if you want to be the maintainer of this package, > I will be happy with it. Please set cvs flag again. Thanks Mamoru, and sorry for the delay. New Package CVS Request ======================= Package Name: rubygem-mocha Short Description: Mocking and stubbing library Owners: kanarip Branches: EL-4 EL-5 F-10 F-11 devel InitialCC: CVS done. Would you rebuild this on koji? By the way the current version is 0.9.7. ping? building now, 0.9.7 rubygem-mocha-0.9.7-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-mocha-0.9.7-1.fc11 rubygem-mocha-0.9.7-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-mocha-0.9.7-1.fc10 rubygem-mocha-0.9.7-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rubygem-mocha-0.9.7-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Could you please build package also for EL-5 ? rubygem-mocha-0.9.7-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-mocha-0.9.7-1.el5 rubygem-mocha-0.9.8-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-mocha-0.9.8-1.fc13 rubygem-mocha-0.9.8-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-mocha-0.9.8-1.fc14 rubygem-mocha-0.9.8-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/rubygem-mocha-0.9.8-1.el5 rubygem-mocha-0.9.8-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-mocha-0.9.8-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. rubygem-mocha-0.9.8-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. Could you please build package also for F-12 ? F-12 should be okay (unless you need 0.9.8) $ koji latest-pkg dist-f12-build rubygem-mocha Build Tag Built by ---------------------------------------- -------------------- ---------------- rubygem-mocha-0.9.7-2.fc12 dist-f12 jkeating ... and it seems you need 0.9.8 on F-12. |