Bug 459983

*** Bug 459982 has been marked as a duplicate of this bug. ***

MUST Items: 

OK - rpmlint is clean
OK - follows Naming Guidelines
OK - spec file is named as %{name}.spec

xx - package does not meet Packaging Guidelines
    + Although this is not explicitly mentioned in the guidelines, you need to
      do 'rm -f $RPM_BUILD_ROOT%{_infodir}/dir' after running
      'make install ...' in the %install stanza to avoid overwriting it while
      installing the package.
    + To preserve timestamps you could consider using:
      make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT
    + The upstream tarball contains an online manual page: doc/moe.1. You
      might consider shipping it. If you do so, then please use 'install -p'
      to install it so that the timestamps are preserved.
    + It is a good idea not to explicitly specify the extension added by the
      compression scheme to the info and manual pages. Using a wildcard will
      let the package build if no compression is used or the extension is
      changed.

OK - Fedora approved license and meets Licensing Guidelines
OK - License field meets actual license
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources

xx - package fails to build successfully
    + Incorrect build dependencies and unpackaged %{_infodir}/dir file, which
      should be removed.

OK - ExcludeArch not needed

xx - build dependencies incorrectly listed
    + Missing 'BuildRequires: ncurses-devel'.

OK - no locales
OK - no shared libraries
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files
OK - -devel is not needed
OK - no libtool archives
OK - %{name}.desktop file not needed
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8

SHOULD Items:

OK - upstream provides license text
xx - no translations for description and summary

xx - package fails to build in mock successfully
    + Incorrect build dependencies and unpackaged %{_infodir}/dir file, which
      should be removed.

OK - package builds on all supported architectures
OK - package functions as expected
OK - scriptlets are sane
OK - subpackages are not needed
OK - no pkgconfig files
OK - no file dependencies

Thanks for the comments and the suggestions. I have updated the package accordingly to remove any blockers. Here are the URLs

Spec URL: http://bonii.fedorapeople.org/spec/moe.spec
SRPM URL: http://bonii.fedorapeople.org/srpms/moe-1.0-2.fc9.src.rpm

You could have used %{name} in the following line since you have used it so frequently elsewhere:
"%{__install} -p -m 644 ./doc/moe.1 $RPM_BUILD_ROOT%{_mandir}/man1/"

+---------------------------------+
| This package is APPROVED by me. |
+---------------------------------+

Thanks for the review Debarshi.

New Package CVS Request
=======================
Package Name: moe
Short Description: A powerful clean text editor
Owners: bonii
Branches: F-8 F-9 
InitialCC:

cvs done

moe-1.0-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/moe-1.0-2.fc9

moe-1.0-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/moe-1.0-2.fc8

This package has been built and submitted as an update in Bodhi.

moe-1.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

moe-1.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.