Bug 460182
| Summary: | Review Request: python-virtualenv - Tool to create isolated Python environments | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Milner <smilner> | |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, phalliday | |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
|
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 519615 (view as bug list) | Environment: | ||
| Last Closed: | 2008-09-14 00:38:38 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
|
Description
Steve Milner
2008-08-26 16:59:53 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=789671 koji build failed suggestions: 1) remove inclusion of virtualenv.py twice warning: File listed twice: /usr/lib/python2.5/site-packages/virtualenv.py remove following line from spec %attr(755,root,root) %{python_sitelib}/virtualenv.py 2) Use BuildRequires: python-setuptools-devel to build egginfo from source. Updated: http://www.stevemilner.org/tmp/python-virtualenv-1.1-2.fc9.src.rpm http://www.stevemilner.org/tmp/python-virtualenv.spec rpmlint output: [steve@tachikoman SPECS]$ rpmlint /home/steve/rpmbuild/RPMS/noarch/python-virtualenv-1.1-2.fc9.noarch.rpm python-virtualenv.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtualenv.py 0644 1 packages and 0 specfiles checked; 1 errors, 0 warnings. [steve@tachikoman SPECS]$ Verifying /usr/bin/virtualenv is there: [steve@tachikoman SPECS]$ rpm -qpl /home/steve/rpmbuild/RPMS/noarch/python-virtualenv-1.1-2.fc9.noarch.rpm | grep bin /usr/bin/virtualenv [steve@tachikoman SPECS]$ Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=792541 + rpmlint is silent for SRPM but NOT for RPM. python-virtualenv.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtualenv.py 0644 + source files match upstream. 8931b66dbb799120583dd107aab2fa89 virtualenv-1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) from http://fedoraproject.org/wiki/Packaging/Python/Eggs#Upstream_Eggs drop file /usr/lib/python2.5/site-packages/support-files/setuptools-0.6c8-py2.5.egg from installing by adding line to %files %exclude %{python_sitelib}/support-files 2) remove rpmlint warning using following command in %prep sed -i -e "s|#!/usr/bin/env python||" virtualenv.py 3) you really don't need "ls" in %build. Remove that. 1. Done 2. Done 3. Done http://www.stevemilner.org/tmp/python-virtualenv-1.1-3.fc8.src.rpm http://www.stevemilner.org/tmp/python-virtualenv.spec Updated for upstream release. http://www.stevemilner.org/tmp/python-virtualenv-1.2-1.fc9.src.rpm http://www.stevemilner.org/tmp/python-virtualenv.spec koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=796292 APPROVED. New Package CVS Request ======================= Package Name: python-virtualenv Short Description: a tool to create isolated Python environments Owners: smilner Branches: F-9, EL-5 cvs done. is this built on build server? Just got back in town and built it in devel http://koji.fedoraproject.org/koji/taskinfo?taskID=824745 *** Bug 519615 has been marked as a duplicate of this bug. *** *** Bug 548877 has been marked as a duplicate of this bug. *** |