Bug 460632
| Summary: | Review Request: ratbox-services - Service package for ircd-ratbox | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lkundrak, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://mmahut.fedorapeople.org/reviews/ratbox-services/ratbox-services.spec | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-02 10:20:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 460538 | ||
| Bug Blocks: | |||
|
Description
Marek Mahut
2008-08-29 10:11:22 UTC
0.) You may want to rename it
I'm not sure if it is usable only with ircd-ratbox, or other ircds. In case it cannot be used with other ircds, name ircd-ratbox-services is much more appropriate.
1.) Do not depend on sendmail
Requires: sendmail
Replace with /usr/bin/sendmail or MTA or smtpdaemon, depending on ho do you use sendmail.
2.) Explain non-obvious commands
sed 's/-Werror//g' -i configure
What's this? Comment it.
Provides: perl(definetolength.pl)
And this?
3.) Fix owners/groups
%config(noreplace) %{_sysconfdir}/logrotate.d/ratbox-services
At least this is not to be owned by ircd. Change %defattr to use root by default and override in %attr-s.
Furthermore, files that contain password should not be world-readable.
You may want to rename this: /usr/bin/dbupgrade.pl Thank you for initial review, (In reply to comment #1) > 0.) You may want to rename it > > I'm not sure if it is usable only with ircd-ratbox, or other ircds. In case it > cannot be used with other ircds, name ircd-ratbox-services is much more > appropriate. Would it make confusion? I'm not very big fun of delaying the original upstream name, if people find on the upstream page the product is called ratbox-services, it should be the same in Fedora (imo). It can be also used with hybrid ircd. > 1.) Do not depend on sendmail > > Requires: sendmail > > Replace with /usr/bin/sendmail or MTA or smtpdaemon, depending on ho do you use > sendmail. Done. > 2.) Explain non-obvious commands > > sed 's/-Werror//g' -i configure We remove usage of -Werror from flags. Once we have all ratbox packages in, I'll inform upstream including patches about it. Comment made in spec file > What's this? Comment it. > > Provides: perl(definetolength.pl) > > And this? Removed. > 3.) Fix owners/groups > > %config(noreplace) %{_sysconfdir}/logrotate.d/ratbox-services > > At least this is not to be owned by ircd. Change %defattr to use root by > default and override in %attr-s. You're right, done. > Furthermore, files that contain password should not be world-readable. Done. New SRPM is uploaded. Seems well, marek; Thanks! APPROVED Thank you. New Package CVS Request ======================= Package Name: ratbox-services Short Description: Service package for ircd-ratbox Owners: mmahut Branches: F-9 EL-5 cvs done. Thank you!! |