Bug 460660
Summary: | Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chris.stone, dhollis, fedora, fedora-package-review, lemenkov, notting |
Target Milestone: | --- | Flags: | chris.stone:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-10-24 12:26:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Rakesh Pandit
2008-08-29 14:47:42 UTC
*** Bug 438804 has been marked as a duplicate of this bug. *** I think %doc should be: %doc %{pear_name}-%{version}/docdir/%{pear_name}/* Thanks, %changelog * Fri Aug 29 2008 Rakesh Pandit <rakesh> 1.6.1-7 - fixed %%doc (Christopher Stone) SPEC: http://rakesh.fedorapeople.org/spec/php-pear-Auth.spec SRPM: http://rakesh.fedorapeople.org/srpm/php-pear-Auth-1.6.1-7.fc9.src.rpm @Chris Interested in continuing review here, as you reviewed the old one ;-) Thanks ==== REVIEW CHECKLIST ==== X rpmlint output: php-pear-Auth-radius.noarch: W: no-documentation php-pear-Auth.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 12) php-pear-Auth-samba.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Please remove all tabs from the spec file. - package named according to package naming guidelines - spec file name matches %[name} - package meets packaging guidelines - licensed under an approved fedora license - %license matches actual license X license file not included in %doc - spec file written in American English - spec file legible - sources match upstream 8d482ac5b07ed74ab8f29430063c6bae Auth-1.6.1.tgz 8d482ac5b07ed74ab8f29430063c6bae ../SOURCES/Auth-1.6.1.tgz - SRPM compiles on x86_64 F-9 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicate files in %files - file permissions set properly - contains a proper %clean section - macro usage is consistent - contains code or permissible content - no large documentation - no header files - no static libraries - no pkgconfig files - no .so files - subpackages properly require parent package - no libtool archives - not a GUI application - package does not own files or directories owned by other packages - buildroot removed in %install - all files valid utf-8 *** APPROVED *** ==== MUST FIX ==== - No items ==== SHOULD FIX ==== - Remove tabs from spec file - Add a copy of the PHP license to %doc (see spec file for php-pear-File for an example) Thanks - Will fix all "should points" before importing. New Package CVS Request ======================= Package Name: php-pear-Auth Short Description: provides methods for creating an authentication system using PHP Owners: rakesh Branches: F-8 F-9 InitialCC: rakesh Cvsextras Commits: yes cvs done php-pear-Auth-1.6.1-8.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/php-pear-Auth-1.6.1-8.fc8 php-pear-Auth-1.6.1-8.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/php-pear-Auth-1.6.1-8.fc9 Imported to RAWHIDE php-pear-Auth-1.6.1-8.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. php-pear-Auth-1.6.1-8.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-pear-Auth New Branches: el6 epel7 Owners: remi Git done (by process-git-requests). |