Bug 460690
| Summary: | Review Request: echo-artist - Automation tools for echo-icon-theme artists | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
| Component: | Package Review | Assignee: | Luya Tshimbalanga <luya> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, luya, notting |
| Target Milestone: | --- | Flags: | luya:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-10 06:44:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Sourada
2008-08-29 18:17:34 UTC
Taking over that package for review that will come soon. Here is a summary: $ rpmlint rpmbuild/SRPMS/echo-artist-0.1-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings $ rpmlint rpmbuild/RPMS/noarch/echo-artist-0.1-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. The package is correctly named according to Package Naming Guidelines https://fedoraproject.org/wiki/Packaging/NamingGuidelines Name of spec files matches the %{name} Package complies to Packaging Guidelines https://fedoraproject.org/wiki/Packaging/Guidelines Package is licensed under LGPLv2 Package is upstream and legible. Source URL matches upstream (https://fedorahosted.org/releases/e/c/echo-icon-theme/) Package does not use BuuldRequires because of scripts and uses Requires only. Package successfully compiled using koji. spec file contains %clean session. Permission is set correctly %defattr(-,root,root,-) Package is a set of script thus does not need .desktop. Uses of macros is consistent. %{buildroot} would be favorite considering the internal change of rpm itself in Fedora 10. filename are in validated UTF-8 format. This package has passed all reviews thus ready to be accepted. (In reply to comment #2) > Uses of macros is consistent. %{buildroot} would be favorite considering the > internal change of rpm itself in Fedora 10. > Good point. Changed :) New SPEC: http://mso.fedorapeople.org/packages/SPECS/echo-artist.spec New SRPM: http://mso.fedorapeople.org/packages/SRPMS/echo-artist-0.1-2.fc9.src.rpm New Package CVS Request ======================= Package Name: echo-artist Short Description: Automation tools for echo-icon-theme artists Owners: mso Branches: F-8 F-9 InitialCC: cvs done. echo-artist-0.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/echo-artist-0.1-2.fc9 echo-artist-0.1-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/echo-artist-0.1-2.fc8 echo-artist-0.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. echo-artist-0.1-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |