Bug 460707
| Summary: | Review Request: httperf - Tool for measuring web server performance | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Moschny <thomas.moschny> |
| Component: | Package Review | Assignee: | Lucian Langa <lucilanga> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lucilanga, notting, pahan |
| Target Milestone: | --- | Flags: | lucilanga:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-16 18:07:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Thomas Moschny
2008-08-29 22:25:43 UTC
Review:
OK source files match upstream :
2968c36b9ecf3d98fc1f2c1c9c0d9341 httperf-0.9.0.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary is OK.
OK description is OK.
OK dist tag is present.
OK build root
OK license field matches the actual license.
OK license is open source-compatible. license text not included upstream.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires are sane:
httperf = 0.9.0-1.fc10
httperf(x86-64) = 0.9.0-1.fc10
=
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libnsl.so.1()(64bit)
libresolv.so.2()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)
OK no shared libraries are added to the regular linker search paths.
N/A owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -doc subpackage is necessary.
OK no headers.
OK no pkgconfig files.
OK no static libraries.
OK no libtool .la files.
N/A not GUI application.
Suggestion:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
To preserve timestamps you could consider using:
make install INSTALL="%{__install} -p" DESTDIR=%{buildroot}
APPROVED.
Thanks for the review! New Package CVS Request ======================= Package Name: httperf Short Description: Tool for measuring web server performance Owners: thm Branches: F-8 F-9 InitialCC: none Cvsextras Commits: yes cvs done. httperf-0.9.0-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/httperf-0.9.0-2.fc8 httperf-0.9.0-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/httperf-0.9.0-2.fc8 httperf-0.9.0-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. httperf-0.9.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |