Bug 460744

Summary: nash misunderstands ppoll() semantics and goes bonkers as a result
Product: [Fedora] Fedora Reporter: Arjan van de Ven <arjan>
Component: mkinitrdAssignee: Peter Jones <pjones>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 9CC: dcantrell, wtogami
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-14 14:33:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Arjan van de Ven 2008-08-30 19:30:21 UTC
Description of problem:

the ppoll() syscall (similar to select and pselect) modifies the content of the timeout argument and it puts in that the time left from the timeout when an event came in.

glibc hides this behavior from applications by making the system call work  
on a copy, but nash uses the system call directly.
the problem is that nash tends to use ppoll in loops and the timeout doesn't 
get reset each time by nash, so if an event comes in just before the exipiry 
of the timer... it then will always ask for near zero time in the future.

example:

        pd.revents = 0;
        while ((rc = nash_ppoll(&pd, 1, top, NULL, 0) < 0)) {
            if (errno != EINTR)
                return -1;        
        }

Comment 1 Arjan van de Ven 2008-08-30 21:58:34 UTC
ok it's even worse than I thought ;(

some places in nash *depend* on the timeout being overwritten, while other places in nash depend on it *not* being overwritten for certain error cases.
Interesting ;(

Comment 2 Bug Zapper 2009-06-10 02:35:10 UTC
This message is a reminder that Fedora 9 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 9.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '9'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 9's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 9 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Bug Zapper 2009-07-14 14:33:14 UTC
Fedora 9 changed to end-of-life (EOL) status on 2009-07-10. Fedora 9 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.