Bug 460959

Nice addition to Fedora. I'll review it.

Hi lemenkov, you may like to have you look here, when free :-)
Thanks

Still here )
Sorry for the delay - I'll review it ASAP.

Doesn't build at my F-9/ppc.

+ mv /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlbase.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlbase.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlbase.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlconvenience.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlconvenience.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlconvenience.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmldom.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmldom.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmldom.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlengine.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlengine.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlengine.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlregionator.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlregionator.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkmlregionator.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libminizip.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libminizip.so.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libminizip.so.0.0.0 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/liburiparser.so /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/liburiparser.so.1 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/liburiparser.so.1.0.5 /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkml/
+ chrpath --delete /var/tmp/libkml-0.4.0-1.fc9-root-petro/usr/lib/libkml/libkmldom_swig_java.so.0.0.0
open: No such file or directory
elf_open: Illegal seek
error: Bad exit status from /var/tmp/rpm-tmp.60804 (%install)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.60804 (%install)
[petro@Sulaco SPECS]

It wouldn't built for F-9, because dependencies are only available it F-10 or rawhide. Not for F-9 or F-8

> because dependencies are only available it F-10 or
rawhide.

No, all dependencies were satisfied on my F9. Probaply you need to add minimal supported versions to dependencies, e.g. not only "BuildRequires: foo", but "BuildRequires: foo >= 1.2.3.4"

# requires swig >= 1.3.35

yes, i will do that. Swig 1.3.35 is not available for F-9, so I wouldn't be making it available for F-9 anyway. 

Thanks

http://rakesh.fedorapeople.org/srpm/libkml-0.4.0-2.fc10.src.rpm
http://rakesh.fedorapeople.org/spec/libkml.spec

Thanks

ping

I'm sorry, Rakesh, but I can't go further (at least until I'll find a box with F-10 installed). I'm releasing my fedora-review flags. If nobody will review this package, I'll restart the review process, but only after I'll update my working machine to F-10.

No worries. I will wait for your update. In the meantime, if I can find someone then very good.

I hope you will update your box soon. ;-)
Thanks

(In reply to comment #10)
> I'm sorry, Rakesh, but I can't go further (at least until I'll find a box with
> F-10 installed). I'm releasing my fedora-review flags. If nobody will review
> this package, I'll restart the review process, but only after I'll update my
> working machine to F-10.

You can use "koji build --scratch dist-f10 libkml-0.4.0-2.fc10.src.rpm" to make koji build the srpm for you for all primary archs.

Peter Lemenkov - interested now ? F10 is already out. :-)

I'll review it )

REVIEW:

- rpmlint is not silent:

[petro@Sulaco SPECS]$ rpmlint ~/downloaded/libkml-*
libkml-devel.ppc: E: only-non-binary-in-usr-lib
4 packages and 0 specfiles checked; 1 errors, 0 warnings.
[petro@Sulaco SPECS]$ 

I think this should be ignored. However I didn't checked whether I can build samples provided. %{__docdir}/libkml-devel-0.4.0/examples ). Another one thing I found questionable is the existence of "third_party" directory in %{__includedir} - we shouldn't allow user to build something against our version of boost.

+ The package is be named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matching the upstream source, as provided in the spec URL.

[petro@Sulaco SOURCES]$ md5sum libkml-0.4.0.tar.gz*
c6317783cec04f2e2dd992b0dd95c028  libkml-0.4.0.tar.gz
c6317783cec04f2e2dd992b0dd95c028  libkml-0.4.0.tar.gz.srpm
[petro@Sulaco SOURCES]$

+ The package successfully compiles and build into binary rpms on at least one primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1033826

+ All build dependencies are listed in BuildRequires.
+ No need to handle locales
+ The package calls ldconfig in %post and %postun.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ the package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT .
+ The package consistently uses macros, as described in the macros section of Packaging Guidelines .
+ The package contains code, or permissable content.
+ No large documentation files
+ Everithing, the package includes as %doc, does not affect the runtime of the application. 
+ Header files are in a -devel package.
+ No static libraries.
+ No pkgconfig(.pc) files
+ The library files that ends in .so (without suffix) are in a -devel package.
+ devel packages requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
+ Not a GUI application
+ The package does not own files or directories already owned by other packages. 
+  At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+  All filenames in rpm packages are valid UTF-8.

So, please, resolve issue with third party libraries (I suspect that it even builds against shipped boost) and I'll continue.

>So, please, resolve issue with third party libraries (I suspect that it even
>builds against shipped boost) and I'll continue.

I had a good interaction upstream(on ML as well as chat) regarding this. And they wanted the third part folder containing particular versions of few dependencies to be there for now, at least till major version change.

I even packaged 1 of missing onces which I maintain now, but they were strickly against pointing to outside that third folder.

All these are Free software, so I guess it should not be a problem. Putting an extra effort in modifying there build system and even if it works and later on we get bugs against which upstream refuses to except would be bad.

So, I would like to keep this third folder till upstream wishes it be there.

Updated to 0.6.1:

http://rakesh.fedorapeople.org/srpm/libkml-0.6.1-1.fc10.src.rpm
http://rakesh.fedorapeople.org/spec/libkml.spec

ping Peter, around ?

Will review during this week (probably). Unfortunately, I have no access to internet at home.

Thanks for your patch http://peter.fedorapeople.org/libkml-third_party_removal.diff

Will update.

http://rakesh.fedorapeople.org/spec/libkml.spec
http://rakesh.fedorapeople.org/srpm/libkml-0.6.1-2.fc10.src.rpm


Applied patch.

OK, good. Since there was no other issues, except the only one with 3rd-party libraries,  this package is

APPROVED.

New Package CVS Request
=======================
Package Name: libkml
Short Description: A KML library written in C++ with bindings to other languagues
Owners: rakesh
Branches: F-9 F-10
InitialCC:
Cvsextras Commits: yes

cvs done, with the exception of F-9 branch (per IRC conversation, this doesn't build on F-9).

libkml-0.6.1-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/libkml-0.6.1-2.fc10

libkml-0.6.1-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libkml'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2772

libkml-0.6.1-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.