Bug 461003

I've no way to test this, but its been sitting for ten weeks and it builds OK so why not?

Is it possible to clean up the grammar in the %description?  The last sentence needs a period, I'm sure, but honestly I don't have enough context to be able to parse it and suggest improvements.

I'm not sure how you arrive at "GPLv2" for the license tag; I can't find any statement of the GPL version in use, which would indicate "GPL+".  Have I missed something?

The package is missing the proper scriptlet dependencies for service and chkconfig:

Requires(post): chkconfig
Requires(preun): chkconfig, initscripts
Requires(postun): initscripts

* source files match upstream.  sha256sum:
   403fc4ce7da01c83bc2b5da8f8d11643c50dcd04e9f80a7a4f8f2deb041b22ce  
   ssbd-0.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
X description could use some cleanup.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
X final provides and requires missing chkconfig and service dependencies.
   config(ssbd) = 0.10-1.fc10
   ssbd = 0.10-1.fc10
   ssbd(x86-64) = 0.10-1.fc10
  =
   /bin/bash
   /bin/sh
   config(ssbd) = 0.10-1.fc10
   libglib-1.2.so.0()(64bit)
   libsndfile.so.1()(64bit)
   libsndfile.so.1(libsndfile.so.1.0)(64bit)

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
X scriptlets OK (service management) but dependencies are missing.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

(In reply to comment #1)
> Is it possible to clean up the grammar in the %description?  The last sentence
> needs a period, I'm sure, but honestly I don't have enough context to be able
> to parse it and suggest improvements.
updated

 
> I'm not sure how you arrive at "GPLv2" for the license tag; I can't find any
> statement of the GPL version in use, which would indicate "GPL+".  Have I
> missed something?
Package contains license text. See COPYING.


> The package is missing the proper scriptlet dependencies for service and
> chkconfig:
> 
> Requires(post): chkconfig
> Requires(preun): chkconfig, initscripts
> Requires(postun): initscripts
updated

new version:

http://lucilanga.fedorapeople.org/ssbd.spec
http://lucilanga.fedorapeople.org/ssbd-0.10-2.fc10.src.rpm

I know the package contains the license text.  But did you actually read it?  It contains version 2 of the GPL, and clause 9 says:

"
If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation.
"

http://fedoraproject.org/wiki/Licensing says:

"
A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include.
"

So, I ask again, where do you see that a version of the GPL is specified?

updated:
http://lucilanga.fedorapeople.org/ssbd.spec
http://lucilanga.fedorapeople.org/ssbd-0.10-3.fc10.src.rpm

This looks good to me.  It would be good to ask upstream directly about the license issue, but this software seems to be pretty old so I don't know if you would get much of a response.

APPROVED

Thank you.

New Package CVS Request
=======================
Package Name: ssbd
Short Description: Voice keyer for use in hamradio
Owners: lucilanga
Branches: F-9 F-10
InitialCC:

cvs done.

ssbd-0.10-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/ssbd-0.10-3.fc9

ssbd-0.10-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/ssbd-0.10-3.fc10

ssbd-0.10-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

ssbd-0.10-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.