Bug 461007
Summary: | Review Request: libftdi - Library to program and control the FTDI USB controller | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lucian Langa <lucilanga> |
Component: | Package Review | Assignee: | Rakesh Pandit <rpandit> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, hobbes1069, notting, vanmeeuwen+fedora |
Target Milestone: | --- | Flags: | rpandit:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-09-29 04:50:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 461050 |
Description
Lucian Langa
2008-09-03 12:30:05 UTC
Builds on rawhide - x86_64 rpmlint output clean: rpmlint libftdi-0.13-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint libftdi-0.13-1.fc10.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint libftdi-debuginfo-0.13-1.fc10.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint libftdi-devel-0.13-1.fc10.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. will do detailed review shortly, Thanks new upstream update: http://lucilanga.fedorapeople.org/libftdi.spec http://lucilanga.fedorapeople.org/libftdi-0.14-1.fc9.src.rpm (In reply to comment #2) > will do detailed review shortly, Thanks ping? sorry, forgot it completely, thanks for reminding, review coming shortly... Review: NA = Not applicable, ! = requires attention, x = passed Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=845010 source from project resource: md5sum libftdi-0.14.tar.gz 43f20478e725aa5ba6cdae311ca0593d libftdi-0.14.tar.gz source from srpm: md5sum libftdi-0.14.tar.gz 43f20478e725aa5ba6cdae311ca0593d libftdi/libftdi-0.14.tar.gz RPMLINT: CLEAN [rpmbuild@rocky SRPMS]$ rpmlint libftdi-0.14-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [rpmbuild@rocky i386]$ rpmlint libftdi-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [rpmbuild@rocky i386]$ rpmlint libftdi-devel-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [rpmbuild@rocky i386]$ rpmlint libftdi-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Required: [x] package name [x] package base name and spec name - same [x] packaging guidelines [x] license file included [x] license correct [x] spec legible & in American english [x] md5sum checked source [x] package compiled on all primary architectures [x] Buildrequires tag - okay [NA] locale [NA] desktop file - GUI [x] shared library - ldconfig called in %post and %postun [x] owns all directories it creates [x] permissions in %defattr correct [x] %clean and %install section have 'rm -rf $RPM_BUILD_ROOT' [x] %doc files don't have any dependency on other section of package [!] Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). You should remove pkgconfig from BuildRequires and put it in Requires Moreover in devel package requires Requires: %{name} = %{version}-%{release} is enough [x] valid encoding Optional: [x] description and summary fine [NA] license file query [x] package functioning - okay [NA] any scripts [x] no dependencies outside FHS guideline paths [x] .pc file in devel pkg Summary: other then one point mentioned in [!] above - everything looks okay > [!] Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for > directory ownership and usability). > You should remove pkgconfig from BuildRequires and put it in Requires > Moreover in devel package requires > Requires: %{name} = %{version}-%{release} is enough updated and bumped version: http://lucilanga.fedorapeople.org/libftdi.spec http://lucilanga.fedorapeople.org/libftdi-0.14-2.fc9.src.rpm APPROVED New Package CVS Request ======================= Package Name: libftdi Short Description: Library to program and control the FTDI USB controller Owners: lucilanga Branches: F-8 F-9 InitialCC: cvs done. libftdi-0.14-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/libftdi-0.14-2.fc8 libftdi-0.14-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/libftdi-0.14-2.fc9 libftdi-0.14-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. libftdi-0.14-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ======================= Package Name: libftdi Short Description: Library to program and control the FTDI USB controller Owners: lucilanga Branches: EL-5 EL-6 InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: libftdi New Branches: epel7 Owners: hobbes1069 lucilanga InitialCC: Git done (by process-git-requests). |