Bug 461105
| Summary: | Review Request: labrea - A sticky honeypot | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Huzaifa S. Sidhpurwala <huzaifas> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lmacken, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-16 02:51:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Huzaifa S. Sidhpurwala
2008-09-04 08:50:57 UTC
Use prefixes in %configure and make install instead %makeinstall fixed. SPEC: http://huzaifas.fedorapeople.org/spec/labrea.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/labrea-2.5.1-1.fc10.src.rpm [huzaifas@localhost SPECS]$ rpmlint ../SRPMS/labrea-2.5.1-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. suggestions->
1)you should drop options to %configure
2)make install should be
make install DESTDIR=%{buildroot} INSTALL="install -p"
3)Drop INSTALL file from %docs
4)macro usage should be unique
either use $RPM_BUILD_ROOT or %{buildroot}
5)buildroot tag should be
%{_tmppath}/%{name}-%{version}-%{release}-root
Submit new SRPM after fixing above issues and bump release
SPEC: http://huzaifas.fedorapeople.org/spec/labrea.spec SRPM: http://huzaifas.fedorapeople.org/srpms/labrea-2.5.1-2.fc10.src.rpm 3)Drop INSTALL file from %docs This has not been done , because the INSTALL file contains instructions on how to use the app :) + is OK - is NEEDs WORK Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=806045 - rpmlint is silent for SRPM. But NOT for RPM. labrea.i386: W: non-conffile-in-etc /etc/labrea.conf ==> use following in SPEC %config(noreplace) %{_sysconfdir}/labrea.conf + source files match upstream. e76d506e82b60cc5477ccee1b3368cda labrea-2.5-stable-1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Don't forget to fix conffile rpmlint message before import. APPROVED. New Package CVS Request ======================= Package Name: labrea Short Description: A sticky honeypot Owners: huzaifas Branches: F-8 F-9 cvs done. ping? is this built already? If yes then you can CLOSE this review bug. sorry for keeping it open, closing it now. |