Bug 461119

Could you update this to the latest version? While you are there you can fix the %{_docdir}/%{name}-%{version} issue. Also, you don't need to add %doc when you are using %{_docdir}

Thx for taking a preliminary review but libtiger isn't considered as ready for wide use at this time by upstream.

I will fix/update the package anyway.

SRPM: http://kwizart.fedorapeople.org/review/libtiger-0.3.3-1.fc11.src.rpm
SPEC: http://kwizart.fedorapeople.org/review/libtiger.spec
Summary: Rendering library for Kate streams using Pango and Cairo

This package is known to be in usable state from upstream. (remove NotReady on Whiteboard)

This package is open for review.

It would be easier to remove %{buildroot}%{_docdir} and add '%doc doc/html' to the %files devel section...

Furthermore docs need to be installed in %{_docdir}/%{name}-%{version}. The above would fix this issue, too.

I will fix
Is this a full review ?

(In reply to comment #5)
> I will fix
> Is this a full review ?  

No. I didn't want to do a full review, when %files is not yet in final state; but will do the rest of it now...


REVIEW:

Good:
- Group ok
- name ok
- description ok
- removing *.la, ok
- no static libs
- libs correctly packaged (ldconfig...)
- timestamps ok
- parallel make
- rpmlint clean
- builds in koji
  https://koji.fedoraproject.org/koji/taskinfo?taskID=1892775


Needswork:
- License is wrong:
  Why BSD? There are LGPLv2+ headers and COPYING.
- %files
  Will check for permissions and so on later.
- BR: - cairo-devel is missing, gets pulled in by pango-devel, but I wouldn't
                                trust that...
      - check for >= 0.2.7 is not needed anymore, but ok
- How about including the examples into -devel, too?

SRPM: http://kwizart.fedorapeople.org/review/libtiger-0.3.3-2.fc11.src.rpm
SPEC: http://kwizart.fedorapeople.org/review/libtiger.spec
Summary: Rendering library for Kate streams using Pango and Cairo

Changelog
- Split doc subpackage (with example)
- Change License Tag (was LGPL)

I've splitted into a -doc subpackage to avoid multilib conflicts with html files generated at build time by doxygen.

Thx for the review, and sorry for the late answear.

(In reply to comment #7)
> Thx for the review, and sorry for the late answear.    

Indeed, pretty bad. Need to to the review from scratch ;)

Addings to the review in comment 6:

- permissions ok
- examples noarch ok
- license is ok


###################################

One thing left:
Please use:
%files doc
%defattr(-,root,root,-)
%doc examples __doc/html

and not
%doc examples __doc/*

This will leave out AUTHORS ChangeLog... which are already in the main package.
(No need to include them twice in two different packages.)


###################################

APPROVED

New Package CVS Request
=======================
Package Name: libtiger
Short Description: Rendering library for Kate streams using Pango and Cairo
Owners: kwizart
Branches: F-12 F-11

CVS done (by process-cvs-requests.py).

Thx for your review, the package was finally imported.

Package Change Request
======================
Package Name: libtiger
New Branches: el5 el6
Owners: kwizart

Git done (by process-git-requests).