Bug 461357

Summary: Code cleanup - tabs vs. spaces
Product: [Fedora] Fedora Reporter: Patryk Zawadzki <patrys>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: marco.crosio, piotrdrag
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-21 05:19:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Cosmetics - replace tabs with spaces none

Description Patryk Zawadzki 2008-09-06 13:34:15 UTC
Created attachment 315951 [details]
Cosmetics - replace tabs with spaces

I've spent most of the last 3 weeks on and off hacking on a PLD installer based on Anaconda. Some of these changes could be pushed upstream but it's hard for me to produce small feature patches as:

* currently git anaconda uses mixed tabs and spaces (I think we all agree that's bad practice)

* all my editors have tabs are set to be 4 characters wide (as I work on a lot of python apps that use tabs instead of spaces and it's a lot more readable this way)

* the two above result in unreadable code so my git repo uses only spaces

* the consequence is that patches would be rather dirty (ignoring whitespace changes results in some indentation changes not being included) :)

Attached is a cosmetic patch that replaces tabs with eight spaces in all .py files (I did this by hand not to replace tabs in string constants). I know this kind of patches is generally not something maintainers love but it would make it much easier to keep our cloned trees in sync with upstream (and provide clean patches).

Comment 1 David Cantrell 2008-11-21 05:19:53 UTC
We've discussed cleaning up the tabs vs. spaces in the code, but we have decided to not do a huge change across the code base, but rather clean up functions as we work on them.  New code will be following a policy of 4-space indentation.