Bug 461425

Summary: Review Request: daap-sharp - DAAP client library for Mono
Product: [Fedora] Fedora Reporter: Ian Burrell <ianburrell>
Component: Package ReviewAssignee: Michel Alexandre Salim <michel>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, lemenkov, michel, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-24 15:13:10 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Ian Burrell 2008-09-07 16:32:12 EDT
This is a re-review of an orphaned package.

Spec URL: http://znark.com/fedora/daap-sharp.spec
SRPM URL: http://znark.com/fedora/daap-sharp-0.3.5-2.fc10.src.rpm
Description: daap-sharp is a DAAP (Digial Audio Access Protocol) implementation.
It is used by Apple's iTunes software to share music.
Comment 1 Peter Lemenkov 2008-09-08 01:06:04 EDT
Seems that it's already in Fedora

http://cvs.fedoraproject.org/viewvc/rpms/daap-sharp/
Comment 2 Ian Burrell 2008-09-10 16:59:43 EDT
(In reply to comment #1)
> Seems that it's already in Fedora
> 
> http://cvs.fedoraproject.org/viewvc/rpms/daap-sharp/

It was in Fedora.  It got orphaned and removed around Fedora 7.  It needs a re-review to be restored.
Comment 3 Michel Alexandre Salim 2008-09-22 13:12:19 EDT
Straightforward review, since the package has already been approved, so these are just clean-up requests.

rpmlint:
daap-sharp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10)

Easiest fix is to open the file in Emacs, select all, then M-x untabify

Package builds OK, but on my system that has monodoc installed, it generates some files that are currently unpackaged:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib64/monodoc/sources/daap-sharp-docs.source
   /usr/lib64/monodoc/sources/daap-sharp-docs.tree
   /usr/lib64/monodoc/sources/daap-sharp-docs.zip

These won't be generated by Koji since monodoc is not installed there, but would you consider adding a BR and packaging them, perhaps in a -doc subpackage?
Comment 4 Michel Alexandre Salim 2008-09-22 14:04:07 EDT
Fails on ppc64, not sure if it's transient or not, but you might want to take a look. If it's replicable you might want to ExcludeArch ppc64 and file a tracking bug (or reuse the Mono ppc64 tracking bug)

http://koji.fedoraproject.org/koji/taskinfo?taskID=836708
Comment 5 Michel Alexandre Salim 2008-10-10 09:20:39 EDT
ping?
Comment 6 Michel Alexandre Salim 2009-03-24 15:13:10 EDT
Closing due to lack of response