Bug 461820
| Summary: | Review Request: neon-backgrounds - Neon desktop backgrounds | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-11 00:03:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Sourada
2008-09-10 20:11:18 UTC
%{_datadir} issue fixed.
New SPEC: http://mso.fedorapeople.org/packages/SPECS/neon-backgrounds.spec
REVIEW (based on updated spec) ======= Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - macro use consistent - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - content, OK - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should Fix: - Source tarball has no upstream URL location. You should really make a home for it and reference the full URL in the spec. APPROVED. New Package CVS Request ======================= Package Name: neon-backgrounds Short Description: Neon desktop backgrounds Owners: mso Branches: F-8 F-9 InitialCC: CVS done. |