Bug 461854

Summary: brp-java-repack-jars cannot handle filenames with spaces
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: redhat-rpm-configAssignee: Jon Masters <jonathan>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 11CC: jonathan, mat.booth, pmatilai
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-12 17:47:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix brp-java-repack-jars
none
patch to brp-java-repack-jars none

Description Orion Poplawski 2008-09-10 22:37:00 UTC
Created attachment 316365 [details]
Patch to fix brp-java-repack-jars

Description of problem:

brp-java-repack-jars cannot handle filenames with spaces.  The attached patch (for the rawhide version) should fix.  Would be nice to set it pushed to F-9 and F-8 as well.

See also bug #243157 for RHEL.

Version-Release number of selected component (if applicable):
redhat-rpm-config-9.0.2-1.fc9.noarch

Comment 1 Mat Booth 2009-04-18 20:32:11 UTC
Just stumbled into this bug doing a rawhide scratch build.

Presumably, the files whose names contain spaces will not make it into the repacked jar. From the build log:

+ /usr/lib/rpm/redhat/brp-java-repack-jars
cp: cannot stat `./references/overview/The': No such file or directory
cp: cannot stat `EMF': No such file or directory
cp: cannot stat `Edit': No such file or directory
cp: cannot stat `Framework': No such file or directory
cp: cannot stat `Overview_040301.doc': No such file or directory
cp: cannot stat `./references/overview/The': No such file or directory
cp: cannot stat `Eclipse': No such file or directory
cp: cannot stat `Modeling': No such file or directory
cp: cannot stat `Framework': No such file or directory
cp: cannot stat `Overview_040301.doc': No such file or directory

Comment 2 Mat Booth 2009-04-18 20:39:39 UTC
(In reply to comment #1)
> Just stumbled into this bug doing a rawhide scratch build.
> 
> Presumably, the files whose names contain spaces will not make it into the
> repacked jar. From the build log:
> 
> + /usr/lib/rpm/redhat/brp-java-repack-jars
> cp: cannot stat `./references/overview/The': No such file or directory
> cp: cannot stat `EMF': No such file or directory
> cp: cannot stat `Edit': No such file or directory
> cp: cannot stat `Framework': No such file or directory
> cp: cannot stat `Overview_040301.doc': No such file or directory
> cp: cannot stat `./references/overview/The': No such file or directory
> cp: cannot stat `Eclipse': No such file or directory
> cp: cannot stat `Modeling': No such file or directory
> cp: cannot stat `Framework': No such file or directory
> cp: cannot stat `Overview_040301.doc': No such file or directory  


Worse, it results in a zero byte file being created called "./references/overview/The"

Comment 3 Orion Poplawski 2009-04-20 16:02:38 UTC
Created attachment 340370 [details]
patch to brp-java-repack-jars

I think this should handle spaces better.

Comment 4 Bug Zapper 2009-06-09 09:43:27 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 5 Mat Booth 2009-07-01 22:18:14 UTC
Stumbled over this again during my periodic packaging activities...

Ping! Is there anybody out there?

Comment 6 Adam Jackson 2009-08-12 17:47:38 UTC
Fixed in rawhide.