Bug 462835

Summary: Review Request: perl-Math-Calc-Units - Human-readable unit-aware calculator
Product: [Fedora] Fedora Reporter: Benny Amorsen <benny+bugzilla>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mail, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-12 21:12:43 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Benny Amorsen 2008-09-19 05:35:54 EDT
Spec URL: <http://amorsen.dk/fedora/perl-Math-Calc-Units.spec>
SRPM URL: <http://amorsen.dk/fedora/perl-Math-Calc-Units-1.06-1.src.rpm>
Description: 
C<Math::Calc::Units> is a simple calculator that keeps track of units. It
currently handles combinations of byte sizes and duration only,
although adding any other multiplicative types is easy. Any unknown
type is treated as a unique user type (with some effort to map English
plurals to their singular forms).
Comment 1 Jason Tibbitts 2008-10-01 14:42:51 EDT
I don't see you in the account system at all; what's your FAS ID?
Comment 2 Benny Amorsen 2008-10-01 15:51:21 EDT
I don't have a Fedora account yet, I'm still at step 1.1.8 in http://fedoraproject.org/wiki/PackageMaintainers/Join
Comment 3 Jason Tibbitts 2008-10-01 16:02:24 EDT
Ahh, then you seem to have missed the text in the box with the red exclamation mark.
Comment 4 Benny Amorsen 2008-10-01 16:27:19 EDT
Yes. Sorry. This is my first package and I need a sponsor. I have created an account "amorsen" in FAS; I will have work approve my CLA as quickly as possible.
Comment 5 Fabian Affolter 2008-10-24 04:11:56 EDT
Just some small comments on your spec file.

release:   1

- add %{?dist} -> Release: 1%{?dist}

license:   GPL or Artistic

- Should be License:  GPL+ or Artistic
  https://fedoraproject.org/wiki/Packaging/Perl#License_tag

buildrequires:  perl(ExtUtils::MakeMaker)

- Should be Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
  https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires

source:    Math-Calc-Units-1.06.tar.gz

- The source should come from upstream.
  Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
  https://fedoraproject.org/wiki/Packaging/SourceURL

%changelog

- add some thning like * Fri Sep 19 2008 <amorsen@terpsichore.ipvision.dk> - 1.06-1

  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

For more details about packaging perl stuff please check https://fedoraproject.org/wiki/Packaging/Perl
Comment 6 Fabian Affolter 2008-11-14 05:42:21 EST
ping?
Comment 7 Jason Tibbitts 2008-12-06 16:55:44 EST
It has been well over a month since comment #5 with no response.  This ticket will be closed soon if there is no further progress.
Comment 8 Jason Tibbitts 2008-12-12 21:12:43 EST
No response; closing.