Bug 463229

Summary:	Review Request: ACE Banners Module
Product:	[Fedora] Fedora	Reporter:	Bryan Kearney <bkearney>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-10-02 19:12:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bryan Kearney 2008-09-22 16:56:20 UTC

Spec URL: http://bkearney.fedorapeople.org/ace-banners.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-banners-0.0.3-2.fc9.src.rpm
Description: Banners module for the Appliance Configuration Enging (see https://bugzilla.redhat.com/show_bug.cgi?id=463226)

Comment 1 Bill Nottingham 2008-09-23 20:05:18 UTC

Is there a better way to package puppet recipes than this? It seems having umpteen subpackages isn't the way to go.

Comment 2 Bryan Kearney 2008-09-23 20:23:56 UTC

I would be happy to discuss real time to find on. The goal is to have the appliance ship with all the correct packages, and not have to call home at initial start up. For that reason, puppet is not used to require packages.. the spec file is. So each subpackage will have a puppet module, and a set of requires.

Comment 3 Bill Nottingham 2008-09-23 20:40:46 UTC

Right, but...

- You've got these weird puppet modules that have initimate knowledge of the configuration details of their apps (file locations, etc.). Why not package them in some form with the app itself? How much will they need changed if the apps themselves change?

- A separate source package for every single module you may want in a appliance sounds like bloat. Are they really intended to be released independently?

Comment 4 Bryan Kearney 2008-09-24 13:28:55 UTC

Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-banners.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-banners-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

Comment 5 Bryan Kearney 2008-10-02 19:12:28 UTC

Combining this package into https://bugzilla.redhat.com/show_bug.cgi?id=463226 as a subpackage.