Bug 463780
| Summary: | Add new logical volume raises exception | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Radek Vykydal <rvykydal> | ||||||||||
| Component: | anaconda | Assignee: | Radek Vykydal <rvykydal> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Alexander Todorov <atodorov> | ||||||||||
| Severity: | high | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | 5.3 | CC: | atodorov, ddumas, jburke, jgranado | ||||||||||
| Target Milestone: | rc | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | i386 | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2009-01-20 21:37:35 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 317675 [details] patch with fix Seems like to be caused by commit 4aa9ca1c35b867fa5a4d94c41591700ca7ab5edb, (bug #415871). The patch should solve this bug while keeping what was intended with patch for #415871 in. (In reply to comment #2) > ............................ while keeping what was intended with patch > for #415871 in. Joel, could you review attached patch that wrt ^^^^? Created attachment 317677 [details]
updated patch with fix
To consider the "round down patch, 4aa9ca1c35b867fa5a4d94c41591700ca7ab5edb" only for the volumes that are described with percent seems OK to me. I'd go ahead and commit it. *** Bug 463843 has been marked as a duplicate of this bug. *** The patch from comment #4 doesn't work. Things seem pretty more complicated. Created attachment 318049 [details] updated fix should fix the bug, also tested against reproducer of original bug #415871 Fixed with commit 08233b0c42f8b453ff7d8bde03c9adc57d92d7ed, should go into anaconda-11.1.2.133. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-0164.html |
Created attachment 317608 [details] traceback file Description of problem: In partition editor after "Remove all partitions on selected drives and create default layout", trying to add a logical partition to VolGroup00 raises exception. Version-Release number of selected component (if applicable): tree: rhel5 20080919 nightly Server i386 anaconda: 11.1.2.126-1 How reproducible: always Steps to Reproduce: 1. in partitioning select "Remove all partitions on selected drives and create default layout" and check "Review and modify partitioning layout", go "Next" 2. in partittion editor edit LogVol00 partition 3. in "Edit LVM Volume Group" dialog delete LogVol00 partition 4. in "Edit LVM Volume Group" dialog click "Add" Actual results: Exception raised Traceback (most recent call first): File "/usr/lib/anaconda/partRequests.py", line 981, in getActualSize retval = lvm.clampLVSizeRequest(retval, vgreq.pesize) File "/usr/lib/anaconda/iw/lvm_dialog_gui.py", line 445, in editLogicalVolume sizeEntry.set_text("%Ld" % (logrequest.getActualSize(self.partitions, self.diskset),)) File "/usr/lib/anaconda/iw/lvm_dialog_gui.py", line 775, in addLogicalVolumeCB self.editLogicalVolume(request, isNew = 1) AttributeError: 'NoneType' object has no attribute 'pesize' Expected results: Dialog for adding should appear Additional info: traceback attached