Bug 464402

Summary:	Review-Request: numptyphysics - A crayon-drawing based physics puzzle game
Product:	[Fedora] Fedora	Reporter:	Lubomir Rintel <lkundrak>
Component:	Package Review	Assignee:	Marek Mahut <mmahut>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mmahut, notting, pahan
Target Milestone:	---	Flags:	mmahut: fedora-review+ huzaifas: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-09-30 08:11:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2008-09-28 07:20:44 UTC

SPEC: http://netbsd.sk/~lkundrak/SPECS/numptyphysics.spec
SRPM: http://netbsd.sk/~lkundrak/SRPMS/numptyphysics-0.3-0.1.20080925svn.el5.src.rpm

Description:

Harness gravity with your crayon and set about creating blocks, ramps,
levers, pulleys and whatever else you fancy to get the little red thing to
the little yellow thing.

Comment 1 Marek Mahut 2008-09-28 09:20:02 UTC

+ package meets naming and versioning guidelines
+ specfile is properly named, is cleanly written and uses macros consistently
+ dist tag is present.
+ license field matches the actual license
+ license is open source-compatible
+ license text not included upstream
+ %clean is present.
+ package builds in mock (f8, rawhide)
+ package installs properly (f8)
+ rpmlint output is sane
+ desktop file install properly

- use %doc to include documentation
- SDL-devel dependency is fetched by SDL_image-devel, it's safe to remove
- desktop file is not (fully) valid:
   ./numptyphysics.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

Comment 2 Lubomir Rintel 2008-09-29 07:35:37 UTC

Thanks for review. New package:

SPEC: http://netbsd.sk/~lkundrak/SPECS/numptyphysics.spec
SRPM:
http://netbsd.sk/~lkundrak/SRPMS/numptyphysics-0.3-0.2.20080925svn.el5.src.rpm

(In reply to comment #1)
> - use %doc to include documentation

There's no documentation in the source tree.

> - SDL-devel dependency is fetched by SDL_image-devel, it's safe to remove

Done.

> - desktop file is not (fully) valid:
>    ./numptyphysics.desktop: warning: key "Encoding" in group "Desktop Entry" is
> deprecated

Fixed.

Comment 3 Marek Mahut 2008-09-29 08:05:59 UTC

Right, that's windows documentation :)

APPROVED.

Comment 4 Lubomir Rintel 2008-09-29 08:46:54 UTC

New Package CVS Request
=======================
Package Name: numptyphysics
Short Description: A crayon-drawing based physics puzzle game
Owners: lkundrak
Branches: F-9 EL-5

Comment 5 Huzaifa S. Sidhpurwala 2008-09-30 04:30:42 UTC

cvs done

Comment 6 Lubomir Rintel 2008-09-30 08:11:05 UTC

Thanks Huzaifa; imported and built.