Bug 464475

+++ This bug was initially created as a clone of Bug #461701 +++

--- Additional comment from xdmoon on 2008-09-09 20:04:27 EDT ---

Public Bug Summary:

Using a satellite with rhns-5.1.1-14 and rhnpush-5.1.1-1 with more than one org, say, default-org and other-org, then switching between the orgs/users when doing multiple uploading of packages will fail with the following error -
[snip]
Result codes: 200 OK
Computing md5sum and package Info .This may take sometime ...

Error Message:
    You are not allowed to manage channel other-org-testing, or that channel
does not exist
Error Class Code: 32
Error Class Info: Channel error
Explanation:
     An error has occurred while processing your request. If this problem
     persists please enter a bug report at bugzilla.redhat.com.
     If you choose to submit the bug report, please be sure to include
     details of what you were trying to do when this error occurred and
     details on how to reproduce this problem.

Looking at the satellite logs with debug=5, I see this:
[snip]

For example: 

1. first push a package for default org with the org admin user, which succeeds:

rhnpush --force --nosig --server $(uname -n) --channel test-default-org-channel -vvv --username admin --password password rhn-html-5.1.1-8.noarch.rpm

2. now push a package for other org with its admin user, which will fail:

rhnpush --force --nosig --server $(uname -n) --channel test-other-org-channel -vvv --username admin-test --password password rhn-html-5.1.1-8.noarch.rpm

This appears to be due to session caching, where the cached session is used for authentication, regardless of the current username/password provided to rhnpush.

Workaround is to either use --no-session-caching as an option to rhnpush, or the following patch:

[root ~]# diff -ru /usr/share/rhn/rhnpush/uploadLib2.py.orig  /usr/share/rhn/rhnpush/uploadLib2.py
--- /usr/share/rhn/rhnpush/uploadLib2.py.orig   2008-05-07 22:48:03.000000000 -0400
+++ /usr/share/rhn/rhnpush/uploadLib2.py        2008-09-09 19:08:06.000000000 -0400
@@ -454,7 +454,7 @@
     #session token authentication
     def new_sat_test(self):
         if self.new_sat is None:
-            if self.options.no_session_caching:
+            if self.options.no_session_caching or self.options.username:
                 self.new_sat = 0
             else:
                 self.new_sat = 1

--- Additional comment from mmraka on 2008-09-26 09:09:28 EDT ---

Hi Xixi,
although your patch works it has a unexpected side effect - it turns session caching entirely off. 
That means after rhnpush --username ... the session key is not stored and subsequent  rhnpush (without --username) will use the key stored by last but one call.
So my fix is: if --username is set use username/password authentication and generate new session key.

--- a/client/tools/rhnpush/uploadLib2.py
+++ b/client/tools/rhnpush/uploadLib2.py
@@ -443,11 +443,11 @@ class UploadClass:
     #After they've entered their username/password, they are passed to the new XMLRPC call 'login', which will 
     #verify the user/pass and return a new session string if they are correct.
     #Need to fix this up so there's less repeated code.
     def authenticate(self):
         #Only use the session token stuff if we're talking to a sat that supports sessi
on-token authentication.
         if self.new_sat_test():
             self.readSession()
-            if self.session and not self.options.new_cache:
+            if self.session and not self.options.new_cache and self.options.username == self.username:
                 chksession = self.checkSession(self.session.getSessionString())
                 if not chksession:
                     self.setUsernamePassword()

--- Additional comment from xdmoon on 2008-09-26 13:44:14 EDT ---

(In reply to comment #6)
Hi Michael,
You're right that's what I meant to do but apparently implemented it wrong...  Thanks for fixing it and for the explanation!
Xixi