Bug 464765

Summary: Network Manager OpenVPN gui fields for CA and personal certs are swapped.
Product: [Fedora] Fedora Reporter: jay dwyer <jason.dwyer>
Component: NetworkManager-openvpnAssignee: Dan Williams <dcbw>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 9CC: choeger, dcbw, steve, tim
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-30 12:58:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for correct labeling none

Description jay dwyer 2008-09-30 11:54:21 UTC
Description of problem:

New network manager openvpn gui has the CA cert and user cert fields swapped, such that the selector for each and what gets stored are vice-versa for each.


Version-Release number of selected component (if applicable):

NetworkManager-openvpn-0.7.0-15.svn4027.fc9.i386

How reproducible:

update to above version, either open an existing open vpn connection or enter a new one. 

existing one will have the current values swapped ( ie the user cert will be selected in the CA cert field, and vice versa )

adding a new one, when you click to select the CA cert, the file selector actually says in the title 'select your personal cert'


Steps to Reproduce:

see above
  
Actual results:

certificate fields are switched

Expected results:

certificate fields will not be switched. a pay rise might also be nice.

Additional info:

when you switch the selections to be not what the gui labels say, openvpn connections from NetworkManager ARE actually working, which pleases me very much!

Comment 1 Christoph Höger 2008-09-30 12:12:30 UTC
I can confirm that for certificate with password connection type. 

So basically the labels CA_Certificate and User Certificate are swapped. 

Working on it.

Comment 2 Christoph Höger 2008-09-30 12:53:47 UTC
Please apply the following patch to 
/usr/share/gnome-vpn-properties/openvpn/nm-openvpn-dialog.glade

by entering the parent directory and applying the patch via 
'patch -p1 < PATHTOPATCH/switch_certificate_label.patch' 
where PATHTOPATCH is wherever you stored that patch.

Comment 3 Christoph Höger 2008-09-30 12:55:59 UTC
Created attachment 318067 [details]
Patch for correct labeling

Comment 4 Christoph Höger 2008-09-30 12:58:04 UTC
Thank you for your contribution. 
I will close this bug for now - I wont do an update for that task but send the patch upstream. 
Feel free to reopen it, if you find other orthographic mistakes ;)

Comment 5 Dan Williams 2008-09-30 19:55:40 UTC
thanks, fixed in svn4127 upstream and will be backported to F8, F9, and F10

Comment 6 Fedora Update System 2008-09-30 20:29:11 UTC
NetworkManager-openvpn-0.7.0-16.svn4027.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/NetworkManager-openvpn-0.7.0-16.svn4027.fc8

Comment 7 Fedora Update System 2008-09-30 20:30:15 UTC
NetworkManager-openvpn-0.7.0-16.svn4027.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/NetworkManager-openvpn-0.7.0-16.svn4027.fc9

Comment 8 jay dwyer 2008-09-30 23:40:03 UTC
phwoor!

i know it was a simple fix, but i logged this bug before i went to bed, and before i wake up its fixed!

nice work guys!

thanks.

Comment 9 Fedora Update System 2008-10-01 06:41:20 UTC
NetworkManager-openvpn-0.7.0-16.svn4027.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-10-01 06:41:56 UTC
NetworkManager-openvpn-0.7.0-16.svn4027.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.