Bug 464805

Summary:	Review Request: hunspell-mi - Maori hunspell dictionary
Product:	[Fedora] Fedora	Reporter:	Caolan McNamara <caolanm>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-10-01 22:11:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Caolan McNamara 2008-09-30 15:37:38 UTC

Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-mi.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-mi-0.20080630-1.fc9.src.rpm
Description: Maori hunspell dictionary

Comment 1 Parag AN(पराग) 2008-10-01 04:37:41 UTC

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=853576
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
81bdb8563e1890466da842fe5e17d9cd  hunspell-mi-0.1.20080630-beta.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2008-10-01 06:50:09 UTC

New Package CVS Request
=======================
Package Name: hunspell-mi
Short Description: Maori hunspell dictionary
Owners: caolanm
Branches: 
InitialCC:

Comment 3 Kevin Fenzi 2008-10-01 19:08:21 UTC

cvs done.

Comment 4 Caolan McNamara 2008-10-01 22:11:15 UTC

This one's for http://en.wikipedia.org/wiki/Doug_Howlett, its as close as I can get to Tongan at the moment :-)