Bug 465370
| Summary: | kde4.sh micro-optimization | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | kdelibs | Assignee: | Than Ngo <than> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 10 | CC: | jreznik, kevin, ltinkl, rdieter, than, tuxbrewr | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-02-04 17:37:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Rex, Kevin, Than handle this with Fedora or bump upstream? The kde4.sh script is part of Fedora packaging. This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle. Changing version to '10'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping We going to act on this or wontfix? yes, it's a worthwhile sh-specific improvement (dang, and I just touched on kde4.sh yesterday). CVS ACLs allowed it so I committed this to kdelibs3 as 6:3.5.10-4 in devel (did not tag nor build). kdelibs ACLs don't seem to allow me to do that. When someone applies this to kde4.sh, while at it, the '-n "$QT_PLUGIN_PATH"' branch below could also be optimized a bit by invoking "kde4-config --path qtplugins" only once and reusing the result. Ping doh, forgot to close: * Mon Jan 12 2009 Rex Dieter <rdieter> - 4.1.96-7 - Slight speedup to profile.d/kde.sh (#465370) kdelibs3-3.5.10-13.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kdelibs3-3.5.10-13.fc10 kdelibs3-3.5.10-13.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 319299 [details] kde4.sh micro-optimization Here's a tiny optimization to kde4.sh: always avoid one stat of /etc/sysconfig/prelink, and also avoid grepping it if $KDE_IS_PRELINKED is already defined. If accepted, should also be applied to kdelibs3's kde.sh. (BTW, I wonder if grepping /etc/sysconfig/prelink is intentionally preferred over sourcing it and then testing $PRELINKING? grepping might be a bit fragile.)