Bug 466137

A-ha, I got it running in a debugger and found it was having trouble getting a resource bundle from ICU.  Turns out the htmladmin uses adminsdk's res_getstring() with the acceptLanguage set to the raw string from the browser, which I still had set to "en-US,en,en-CA,en-us,EN-US,EN,es-ES,es,no-NO,no,en-gb,ro-RO,ro,utf-8,utf,de-DE" after testing the SP7 security stuff.  ICU chokes on that locale and returns U_ILLEGAL_ARGUMENT_ERROR.  Returning my intl.accept_languages to the default fixes it.

There is no crash when it fails to resolve the locale, htmladmin just prints nothing at all since all the resource string lookups return empty strings.

It is the double quotes which is throwing it off.  That is, en-US,en,en-CA,en-us,EN-US,EN,es-ES,es,no-NO,no,en-gb,ro-RO,ro,utf-8,utf,de-DE will work, but not "en-US,en,en-CA,en-us,EN-US,EN,es-ES,es,no-NO,no,en-gb,ro-RO,ro,utf-8,utf,de-DE"

You cannot set the language string to something containing quotes with the regular Preferences->Languages Choose... dialog, you have to go to
about:config
and set intl.accept_languages to the above value.

Furthermore, the browser (or perhaps Apache) will parse and append the string before it gets to htmladmin, and the value will be
 "en-US,en;q=0.9,en-CA;q=0.9,en-us;q=0.8,EN-US;q=0.8,EN;q=0.7,es-ES;q=0.6,es;q=0.6,no-NO;q=0.5,no;q=0.4,en-gb;q=0.4,ro-RO;q=0.3,ro;q=0.3,utf-8;q=0.2,utf;q=0.1,de-DE";q=0.1

This is what I've found in my testing.  At any rate, it looks as though the fix is to handle U_ILLEGAL_ARGUMENT_ERROR, and just use the default language in that case.

Created attachment 325619 [details]
diffs

Created attachment 325699 [details]
cvs commit log

Reviewed by: nkinder (Thanks!)
Fix Description: If the locale string passed in to res_getstring is bogus, the CGI will just exit (no crash, no security problems) which causes the 500 error.  ures_open returns U_ILLEGAL_ARGUMENT_ERROR if the locale string is bogus.  In this case, just use NULL for the locale which will cause it to use the default one.
Platforms tested: RHEL5
Flag Day: no
Doc impact: no

fix verified - RHEL 5 - DS 8.1  Red Hat Administration Express available, able to view log and stop servers

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-0455.html