Bug 466241

Summary: Review Request: starlab - A Software Environment for Collisional Stellar Dynamics
Product: [Fedora] Fedora Reporter: Lubomir Rintel <lkundrak>
Component: Package ReviewAssignee: Marek Mahut <mmahut>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: mmahut: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-13 10:53:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2008-10-09 11:53:21 UTC
SPEC: http://netbsd.sk/~lkundrak/SPECS/starlab.spec
SRPM: http://netbsd.sk/~lkundrak/SRPMS/starlab-4.4.3-2.el5.src.rpm

Description:

Starlab is a collection of modular software tools designed to simulate the
evolution of stars and stellar systems, and analyze the resulting data.

Starlab consists of a library of loosely coupled programs, sharing a common
flexible data structure, which can be combined in arbitrarily complex ways
to study the dynamics and evolution of binary and multiple star systems,
star clusters and galactic nuclei.

Comment 1 Lubomir Rintel 2008-10-09 11:54:17 UTC
Assigning to marek, since he already informally began the review and pointed out problems that were in turn solved.

Comment 2 Lubomir Rintel 2008-10-09 11:55:07 UTC
Last time I checked rpmlint was silent, and mock builds in el5 and devel succeeded.

Comment 3 Marek Mahut 2008-10-09 21:23:43 UTC
+ source files match upstream:
     211f313ffbef0e7a477c234ee00b8adb (upstream changes this from time to time)
+ package meets naming and versioning guidelines
+ specfile is properly named, is cleanly written and uses macros consistently
+ dist tag is present
+ %clean is present
+ package builds in mock (f8, devel)
+ package installs properly (f8)
- file /usr/bin/starplot from install of starlab-4.4.3-1.fc8.i386 conflicts with file from package starplot-0.95.5-1.fc8.i386

Please fix this issue, probably by renaming (and documenting) it :)

Comment 4 Lubomir Rintel 2008-10-11 20:42:58 UTC
(In reply to comment #3)
> - file /usr/bin/starplot from install of starlab-4.4.3-1.fc8.i386 conflicts
> with file from package starplot-0.95.5-1.fc8.i386

I renamed it to tstarplot (as opposed to xstarplot, which is X11-based displayer)

SPEC: http://netbsd.sk/~lkundrak/SPECS/starlab.spec
SRPM: http://netbsd.sk/~lkundrak/SRPMS/starlab-4.4.3-3.el5.src.rpm

Comment 5 Marek Mahut 2008-10-11 20:51:36 UTC
Thanks, you rock. approved.

Comment 6 Lubomir Rintel 2008-10-12 07:21:03 UTC
New Package CVS Request
=======================
Package Name: starlab
Short Description: A Software Environment for Collisional Stellar Dynamics
Owners: lkundrak
Branches: EL-5 F-9

Comment 7 Kevin Fenzi 2008-10-13 01:56:47 UTC
cvs done.

Comment 8 Lubomir Rintel 2008-10-13 10:53:50 UTC
Thanks for the review Marek!
Thanks for CVS branches Kevin!
Thanks for the package Lubomir. Eeeek.