Bug 466301 (ario)
Summary: | Review Request: ario - Music Player Daemon Client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John F <johnhford> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, itamar, mtasaka, notting, sardemff7+redhat |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-25 07:39:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
John F
2008-10-09 16:41:55 UTC
Also, this is my first package, so I am looking for a sponsor. I am a student at Seneca College and I am looking to package JBoss for Fedora, so I'd like to become a maintainer so I can work more efficiently on my efforts. Thanks Some notes: * License - License tag should be "GPLv2+". * Redundant BuildRequires - Please try to remove redundant BuildRequires * gtk2-devel is required by libglade2-devel * glib2-devel is required by gtk2-devel * avahi-devel is required by avahi-glib-devel * libglade2-devel is required by libgnomeui-devel and libgnomeui-devel is required by libgnomedb-devel * perl module dependency - For rpms providing perl module virtual Provides, please use perl module names for (Build)Requires, not using rpm names directly: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides In this case "BuildRequires: perl(XML::Parser)" must be used. * Unneeded Requires: - "Requires: gtk2" and so on must all be removed. rpmbuild checks the dependencies related to libraries automatically and adds them to the rebuilt binary rpms: https://fedoraproject.org/wiki/Packaging/Guidelines#Requires * Timestamps - To keep timestamps on installed files as much as possible, please consider to use: -------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" -------------------------------------------------- This method usually works for Makefiles generated by recent autotools. * desktop file install - When desktop file is to be installed, desktop-file-{install,validate} must be used: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage ! By the way for Icon entry "Icon=ario" is preferred: https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files * %find_lang - gettext .mo files must be handled by %find_lang: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files * Static archives - static archives *.a files are not needed for this package and must be removed: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries * Documents - Usually "INSTALL" file is for people who want to compile and install a package by themselves and is not needed for people using rpm. - There is no need to ship zero-size "README" file. ping? Hi Mamoru, I am just in the middle of midterms right now. Thanks for your recomendations! I will be fixing the package on Nov 1, 2008 if all goes to plan Thanks again! John Okay, thank you for reply. Hi Mamoru, I have fixed these issues. Sorry it took a while, I have been super busy. Specfile: http://matrix.senecac.on.ca/~jhford/fedora/ario.spec SRPM: http://matrix.senecac.on.ca/~jhford/fedora/ario-1.1-4.fc10.src.rpm Thanks for your time and input, I really appreciate it! John For -4: * More (Build)Requires fixes - "BuildRequires: gettext-devel" is excessive and "BuildRequires: gettext" is enough - "Requires: gettext" is not needed. * sed usage --------------------------------------------------------- sed s/ario.png/ario/ < %{buildroot}/%{_datadir}/applications/ario.desktop \ > %{buildroot}/%{_datadir}/applications/ario.desktop.new rm %{buildroot}/%{_datadir}/applications/ario.desktop mv %{buildroot}/%{_datadir}/applications/ario.desktop.new \ %{buildroot}/%{_datadir}/applications/ario.desktop --------------------------------------------------------- - First of all fixing data/ario.desktop.in.in at %prep instead of fixing installed ario.desktop is preferred (for --short-circuit issue) - Then you can -i option of sed. --------------------------------------------------------- sed -i -e 's|ario\.png|ario|' data/ario.desktop.in.in --------------------------------------------------------- * libtool .la files - Usually installed libtool .la files _must_ be removed. https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries * %find_lang - The comment --------------------------------------------------------- # At some point it might be a good move to use %lang(xx) for the locales --------------------------------------------------------- is no longer needed because %find_lang actually does this (you can check the contents of Ario.lang) Hi Mamoru, I have made the required changes: http://matrix.senecac.on.ca/~jhford/fedora/ario.spec http://matrix.senecac.on.ca/~jhford/fedora/ario-1.1-5.fc10.src.rpm Thanks again, it is really helpful! John Well, * In the comments or %changelog, please use %% instead of % to make it sure that macros won't be expanded in them (please fix it in Fedora CVS) Now + This package itself is now okay + As written on http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored New Fedora packagers to be sponsored are requested to either - submit another review request with enough quality - do a "pre-review" of other person's review request You have another review request (bug 470703). While there is something which needs fixing, it seems good to some extent. ------------------------------------------------------------------ This package (ario) is APPROVED by mtasaka ------------------------------------------------------------------ Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". After you request for sponsorship a mail will be sent to sponsor members automatically (which is invisible for you) which notifies that you need a sponsor. After that, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 8/9/10, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Hi Mamoru, I have applied to "Fedora Packager CVS Commit Group (packager)" in FAS. Thank you for all your help! John Now I am sponsoring you. Please follow "Join" wiki again. Removing NEEDSPONSOR. New Package CVS Request ======================= Package Name: ario Short Description: Ario Music Player Daemon Client Owners: john64 Branches: F-8 F-9 F-10 InitialCC: john64 cvs done. Please rebuild this package on koji and for F-10/8/9 please submit push requests on bodhi: https://admin.fedoraproject.org/updates/ ping? ping again? Please also submit a push request for F-10 on bodhi. ping again? ping again? As this package is already in dist-f11, I close this bug for now... *** Bug 559301 has been marked as a duplicate of this bug. *** |