Bug 466422
Summary: | RHEL5.3: Modify SATA IDE mode quirk | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Shane Huang <shane.huang> | ||||
Component: | kernel | Assignee: | David Milburn <dmilburn> | ||||
Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 5.3 | CC: | benl, bhavna.sarathy, crane.cai, cward, dzickus, henry.su, jgarzik, joachim.deguara, lwang, mgahagan, peterm, prarit, rdoty, shane.huang, syeghiay, tao, tom.gao, wmealing | ||||
Target Milestone: | rc | Keywords: | Regression | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | RHBA-2008-0314 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-01-20 19:50:53 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 432652 | ||||||
Bug Blocks: | 364381 | ||||||
Attachments: |
|
Description
Shane Huang
2008-10-10 07:39:28 UTC
REOPEN this bug for RHEL5.3 because RedHat lost this bug during the update to sata driver, which leads to S3 resume failure again! The patch has been attached, which was generated with kernel 2.6.18-118, please add it ASAP. Thanks Updated flags. This bugzilla has Keywords: Regression. Since no regressions are allowed between releases, it is also being proposed as a blocker for this release. Please resolve ASAP. RHEL5.3 Alpha released last week uses kernel -118, which contains the bug. I wonder whether this bug will be fixed by RHEL5.3 Beta to be released this month? Thanks Jeff and Russell, There is no update to this BZ these days, are you going to add the patch to RHEL5.3 Beta? So that our QA can verify it with Beta. Thanks Shane Issue #234266 has been created on RedHat Issue Tracker for this bug. please check it. *** Bug 469140 has been marked as a duplicate of this bug. *** This patch is still missing in RHEL5.3 Snapshot2 (kernel -122), neither the next version kernel -123, please pursue it further. Hello Shane, Would you please do a quick test with kernel-2.6.18-123.el5.bz466422.1? When updating the RHEL5.3 ahci driver I did not carry forward Bhavana's ahci changes that went into RHEL5.2, sorry about that. Thanks. http://people.redhat.com/dmilburn/ Shane, Also, do we need check for other device IDs besides 0x4380 and 0x4390, the ahci driver supports other SB700/800 devices? Can you please provide more details, why do we not need to check for 0x4391 thru 0x4395? Thanks, David Hi David, Please take a look to drivers/pci/quirks.c static void __devinit quirk_amd_ide_mode(struct pci_dev *pdev) { /* set sb600/sb700/sb800 sata to ahci mode */ u8 tmp; pci_read_config_byte(pdev, PCI_CLASS_DEVICE, &tmp); if (tmp == 0x01) { pci_read_config_byte(pdev, 0x40, &tmp); pci_write_config_byte(pdev, 0x40, tmp|1); pci_write_config_byte(pdev, 0x9, 1); pci_write_config_byte(pdev, 0xa, 6); pci_write_config_byte(pdev, 0x40, tmp); pdev->class = PCI_CLASS_STORAGE_SATA_AHCI; printk(KERN_INFO "PCI: set SATA to AHCI mode\n"); } } DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_amd_ide_mode); DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_amd_ide_mode); This function above forces SB600/SB700 IDE mode(0x4380/0x4390) into AHCI mode to use ahci driver. But the "force" will get lost at ACPI S3 resume, that's why we need to create this BZ and and the fixup patch for S3 resume. As to 0x4391~4395, they are not IDE mode, which need NOT the fixup at S3 resume of course. Thanks, David, kernel-2.6.18-123.el5.bz466422.1 can work on my SB700 platform, please help to add the patch to RHEL5.3 kernel. Thanks Thank you Shane, I have submitted for internal review. in kernel-2.6.18-125.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Verified with kernel-2.6.18-125.el5, thanks. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-0225.html |