Bug 4665

Summary: file-3.27 introduces bug
Product: [Retired] Red Hat Raw Hide Reporter: barsnick
Component: fileAssignee: Crutcher Dunnavant <crutcher>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: medium    
Version: 1.0CC: barsnick
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 1999-08-23 22:08:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description barsnick 1999-08-23 09:10:12 UTC
file-3.27 introduces a bug in the recognition of stripped
ELF files (not only on Linux, BTW). They are reported as
"not stripped", which causes heavy activism trying to debug
SPEC files e.g.  ;-) This bug has been reported to the
authors of the program. No new version has been made
available yet, though.

Fix:
--- file-3.27/readelf.c.strip   Sun Feb 14 18:16:10 1999
+++ file-3.27/readelf.c Sat May 29 09:46:26 1999
@@ -147,7 +147,7 @@
        for ( ; num; num--) {
                if (read(fd, sh_addr, size) == -1)
                        error("read failed (%s).\n",
strerror(errno));
-               if (shs_type == SHT_SYMTAB || shs_type ==
SHT_DYNSYM) {
+               if (shs_type == SHT_SYMTAB) {
                        (void) printf (", not stripped");
                        return;
                }

Further patches (for magic) are available from me.

Comment 1 Jeff Johnson 1999-08-23 14:06:59 UTC
THanks for the patch. Please send the magic patches too ...

Comment 2 Jeff Johnson 1999-08-23 22:08:59 UTC
Fixed in file-3.37-3. Thanks for the patch. I added the magic changes
too.