Bug 466509

Summary:	When prompted for a passphrase after a failure to connect, it's in hex and not the original text you entered
Product:	Red Hat Enterprise Linux 5	Reporter:	Suzanne Hillman <shillman>
Component:	NetworkManager	Assignee:	Dan Williams <dcbw>
Status:	CLOSED ERRATA	QA Contact:	desktop-bugs <desktop-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.3	CC:	benl, rlerch, syeghiay, zcerza
Target Milestone:	rc	Keywords:	Desktop, Regression
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	when NetworkManager fails to connect to a wifi network, it re-prompts the user for the passphrase for that network. Previously, NetworkManager did not retain the original text of the passphrase entered by the user. Therefore, when users selected the "Show password" option so that they could see what they had typed after a failed connection attempt, NetworkManager displayed the passphrase in hexadecimal form. NetworkManager now retains the original text of the passphrase and displays the original passphrase instead of a hexadecimal string when the user selects the "Show password" option.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-02 11:54:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Suzanne Hillman 2008-10-10 16:51:43 UTC

Description of problem:
When prompted for a passphrase after a failure to connect, it's in hex and not the original text you entered. This makes it a bit confusing to tell if you mistyped it the first time, or something else is going on.

Version-Release number of selected component (if applicable):
NM-0.7.0-0.11.svn4133.el5

How reproducible:
Always

Steps to Reproduce:
1. Enter an incorrect passphrase for a wireless access point, with "Show password" checked so you can see what you're doing.

Actual results:
It'll prompt you again, but the passphrase will be hex, not your original string, so you have to retype the whole thing. (again, check 'Show Password')

Expected results:
Prompt should contain what you typed the first time, so you can tell if you made a mistake or if something else is going on.

Additional info:
No idea if this is a regression; I can't recall, and it was not something I thought to note in previous releases as working or not.

Comment 6 Dan Williams 2008-10-23 13:39:03 UTC

I can give this a shot this weekend perhaps.  It's not a small fix though.

Comment 7 Dan Williams 2008-11-12 22:13:13 UTC

Punting to 5.4; it's a cosmetic regression, not a functional regression, and is too invasive to fix at this point in time.

Comment 8 RHEL Program Management 2008-11-12 22:30:31 UTC

This bugzilla has Keywords: Regression.  

Since no regressions are allowed between releases, 
it is also being marked as a blocker for this release.  

Please resolve ASAP.

Comment 9 Dan Williams 2009-05-10 03:49:13 UTC

fixed upstream in commits:

NM:

f3c9887472ef6d773aeabd0bb7fcf102cf725398 (0.7.x)
07cc26d5fc3df0ed47b4bb993ce9a0d4f0008876 (master)

applet:

1009da18d3e8fb9a86a01b43d27bd5cfc3a46336 (0.7.x)
e5fd1d53484aa182ca1ddaf602d4df700c29722f (0.7.x)
d9c45bfcf9db522c1724097341016cfca4e2fb78 (master)
574977f56fffa5725a7418ab3247681a4c1fe47e (master)

Comment 10 Dan Williams 2009-05-10 04:25:35 UTC

nm-wifi-passphrase-not-hex-rh466509.patch
nm-applet-wifi-passphrase-not-hex-rh466509.patch

Comment 12 Ruediger Landmann 2009-05-25 02:12:21 UTC

Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
when NetworkManager fails to connect to a wifi network, it re-prompts the user for the passphrase for that network. Previously, NetworkManager did not retain the original text of the passphrase entered by the user. Therefore, when users selected the "Show password" option so that they could see what they had typed after a failed connection attempt, NetworkManager displayed the passphrase in hexadecimal form. NetworkManager now retains the original text of the passphrase and displays the original passphrase instead of a hexadecimal string when the user selects the "Show password" option.

Comment 13 Zack Cerza 2009-06-15 17:06:42 UTC

Verified on NetworkManager-0.7.0-7.el5.{i386,x86_64}.

Comment 15 errata-xmlrpc 2009-09-02 11:54:02 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1389.html